|
[AMD Public Use]
Indeed. I was trying to keep it all in there anyways to make less churn, but I can remove it altogether, including the definitions that aren’t supported. I was informed that it wasn’t supported nor working correctly, so I’ll revert both
patches (definitions and adding support) for clarity. Thanks!
Kent
From: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Sent: Thursday, May 7, 2020 11:10 AM
To: Russell, Kent <Kent.Russell@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] drm/amdgpu: Don't report unique_id for Arcturus
[AMD Public Use]
Shouldn't all of this code be moved later anyway to make sure the SMU is up and running already?
This isn't supported in the SMU yet, so just break early. This can be
reverted once the SMU supports the feature
Signed-off-by: Kent Russell <kent.russell@xxxxxxx>
Change-Id: I09945613aa7400afdf3f9d5dc0ffb636ee2896f7
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
index f55f9b371bf2..cb90825aacf1 100644
--- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
@@ -317,6 +317,11 @@ static int arcturus_tables_init(struct smu_context *smu, struct smu_table *table
smu_table->metrics_time = 0;
if (smu->adev->asic_type == CHIP_ARCTURUS) {
+ /* TODO: SMU doesn't currently support this. Return
+ * early and remove this once SMU supports it
+ */
+ return 0;
+
/* Get the SN to turn into a Unique ID */
smu_send_smc_msg(smu, SMU_MSG_ReadSerialNumTop32,
&top32);
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://nam11.safelinks.protection.outlook.com/?url="">
|
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
