RE: [PATCH 2/2] drm/amdgpu: Add unique_id for Arcturus

["Quan, Evan" <Evan.Quan@xxxxxxx>]

[AMD Official Use Only - Internal Distribution Only]

arcturus_tables_init() is performed on ip sw_init when the SMU hw may be not ready for message handling.
I would suggest to put this in some API of later SMU hw_init.

Regards,
Evan
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Kent Russell
Sent: Tuesday, April 28, 2020 12:48 AM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Russell, Kent <Kent.Russell@xxxxxxx>
Subject: [PATCH 2/2] drm/amdgpu: Add unique_id for Arcturus

Add support for unique_id for Arcturus, since we only have the ppsmc
definitions for that added at the moment

Signed-off-by: Kent Russell <kent.russell@xxxxxxx>
Change-Id: I66f8e9ff41521d6c13ff673587d6061c1f3f4b7a
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
index e98d92ec1eac..f55f9b371bf2 100644
--- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
@@ -293,6 +293,7 @@ static int arcturus_get_workload_type(struct smu_context *smu, enum PP_SMC_POWER
 static int arcturus_tables_init(struct smu_context *smu, struct smu_table *tables)
 {
 struct smu_table_context *smu_table = &smu->smu_table;
+uint32_t top32, bottom32;

 SMU_TABLE_INIT(tables, SMU_TABLE_PPTABLE, sizeof(PPTable_t),
        PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM);
@@ -315,6 +316,15 @@ static int arcturus_tables_init(struct smu_context *smu, struct smu_table *table
 return -ENOMEM;
 smu_table->metrics_time = 0;

+if (smu->adev->asic_type == CHIP_ARCTURUS) {
+/* Get the SN to turn into a Unique ID */
+smu_send_smc_msg(smu, SMU_MSG_ReadSerialNumTop32,
+ &top32);
+smu_send_smc_msg(smu, SMU_MSG_ReadSerialNumBottom32,
+ &bottom32);
+
+smu->adev->unique_id = ((uint64_t)bottom32 << 32) | top32;
+}
 return 0;
 }

--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cevan.quan%40amd.com%7Ce1f630b561f3402e0abc08d7eacab98c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637236029365851744&amp;sdata=re07oSC474wvdHv7wWJCVYxj842eihH%2Fkr0Sz0YoE94%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx