>> But i have to say there are so many code not follow the kernel code-style in amdgpu module. >> And also the ./scripts/checkpatch.pl did not throw any warning or error. > > That is unfortunately true, yes. But we try to push new code through the usual code review and improve things as we go. > > On the other hand patches just to fix the coding style are usually seen as an unnecessary interruption and just a waste of time. Would you become interested in adjusting deviations from known programming guidelines in an automatic way with the help of corresponding advanced development tools? Regards, Markus _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx