[AMD Public Use] The series is: Reviewed-by: John Clements <john.clements@xxxxxxx> -----Original Message----- From: Chen, Guchun <Guchun.Chen@xxxxxxx> Sent: Monday, April 20, 2020 8:56 PM To: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Clements, John <John.Clements@xxxxxxx> Subject: RE: [PATCH 0/8] psp code clean up [AMD Public Use] The series is: Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx> Regards, Guchun -----Original Message----- From: Zhang, Hawking <Hawking.Zhang@xxxxxxx> Sent: Monday, April 20, 2020 6:17 PM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Clements, John <John.Clements@xxxxxxx>; Chen, Guchun <Guchun.Chen@xxxxxxx> Cc: Zhang, Hawking <Hawking.Zhang@xxxxxxx> Subject: [PATCH 0/8] psp code clean up the seires make cleanup in current software psp support, including: 1). retire unnecessary ip callback function like support_vmr_ring, check_fw_loading. 2). remove unnecessary tOS version check 3). create common helper functions to avoid duplicate code per IP generation Hawking Zhang (8): drm/amdgpu: retire support_vmr_ring interface drm/amdgpu: remove unnecessary tOS version check drm/amdgpu: retire unused check_fw_loading status drm/amdgpu: add helper function to init asd ucode drm/amdgpu: switch to helper function to init asd ucode drm/amdgpu: add helper function to init sos ucode drm/amdgpu: switch to helper function to init sos ucode drm/amdgpu: retire legacy vega10 sos version check drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 130 ++++++++++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 14 +- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 141 +---------------- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 235 ++-------------------------- drivers/gpu/drm/amd/amdgpu/psp_v12_0.c | 172 +-------------------- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 262 +++----------------------------- 6 files changed, 149 insertions(+), 805 deletions(-) -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx