Re: [PATCH] drm/amdgpu/powerplay:avoid to show invalid DPM table info

[Huang Rui <ray.huang@xxxxxxx>]

On Wed, Apr 15, 2020 at 07:20:31PM +0800, Yuxian Dai wrote:
> we should avoid to show the invalid level value when the
> DPM_LEVELS supported number changed
> 
> Signed-off-by: Yuxian Dai <Yuxian.Dai@xxxxxxx>
> Change-Id: Ib66d0cf34a866fa6f0cedd1d5fc642f59236787d

Please add comment in the commit message to explain some asic only have 2
level, and cause the invalid level as 0.

With that fixed, patch is

Reviewed-by: Huang Rui <ray.huang@xxxxxxx>

> ---
>  drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> index 281b7b6cf1a4..e4e7a352d032 100644
> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> @@ -296,6 +296,8 @@ static int renoir_print_clk_levels(struct smu_context *smu,
>  
>  	for (i = 0; i < count; i++) {
>  		GET_DPM_CUR_FREQ(clk_table, clk_type, i, value);
> +		if (!value)
> +			continue;
>  		size += sprintf(buf + size, "%d: %uMhz %s\n", i, value,
>  				cur_value == value ? "*" : "");
>  		if (cur_value == value)
> -- 
> 2.17.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cray.huang%40amd.com%7C4858c507c09943274af508d7e12f15a1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637225464660212899&amp;sdata=eNcYS0dWUHPpQQXPHD6M5%2BqRI8dj1OC2auB0ZQB9Rgs%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx