06:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Vega 10 [Radeon PRO WX 8100] (prog-if 00 [VGA controller]) Subsystem: Advanced Micro Devices, Inc. [AMD/ATI] Vega Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Interrupt: pin A routed to IRQ 10 Region 0: Memory at 2fe0000000 (64-bit, prefetchable) [disabled] [size=256M] Region 2: Memory at 2ff0000000 (64-bit, prefetchable) [disabled] [size=2M] Region 4: I/O ports at d000 [disabled] [size=256] Region 5: Memory at dfc00000 (32-bit, non-prefetchable) [disabled] [size=512K] Expansion ROM at dfc80000 [disabled] [size=128K] Capabilities: <access denied> Kernel modules: amdgpu Adapter 1 SEG=0000, BN=06, DN=00, PCIID=68681002, SSID=0A0C1002) Asic Family : Vega10 Flash Type : M25P80 (1024 KB) Product Name : Vega10 D05111 32Mx128 8GB 852e/1000m 1.00V Bios Config File : D0511100.109 Bios P/N : 113-D0511100-109 Bios Version : 016.001.001.000.011125 Bios Date : 09/22/18 10:48 ROM Image Type : Hybrid Images ROM Image Details : Image[0]: Size(61952 Bytes), Type(Legacy Image) Image[1]: Size(43520 Bytes), Type(EFI Image) 发件人: "Liang, Prike" <Prike.Liang@xxxxxxx> 日期: 2020年4月13日 星期一 12:23 收件人: "Pan, Xinhui" <Xinhui.Pan@xxxxxxx>, Johannes Hirte <johannes.hirte@xxxxxxxxxxxxx> 抄送: "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Quan, Evan" <Evan.Quan@xxxxxxx>, "amd-gfx@xxxxxxxxxxxxxxxxxxxxx" <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> 主题: RE: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video playback (v2) Could you share the PCI sub revision and I try check the issue on the Vega10(1002:687f) but can’t find the reboot hang up. Thanks, Prike From: Pan, Xinhui <Xinhui.Pan@xxxxxxx> Sent: Sunday, April 12, 2020 2:58 PM To: Johannes Hirte <johannes.hirte@xxxxxxxxxxxxx>; Liang, Prike <Prike.Liang@xxxxxxx> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video playback (v2) Prike I hit this issue too. reboot hung with my vega10. it is ok with navi10. From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Liang, Prike <Prike.Liang@xxxxxxx> Sent: Sunday, April 12, 2020 11:49:39 AM To: Johannes Hirte <johannes.hirte@xxxxxxxxxxxxx> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> Subject: RE: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video playback (v2) Thanks update and verify. Could you give more detail information and error log message about you observed issue? Thanks, Prike > -----Original Message----- > From: Johannes Hirte <johannes.hirte@xxxxxxxxxxxxx> > Sent: Sunday, April 12, 2020 7:56 AM > To: Liang, Prike <Prike.Liang@xxxxxxx> > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander > <Alexander.Deucher@xxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; > Quan, Evan <Evan.Quan@xxxxxxx> > Subject: Re: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video > playback (v2) > > On 2020 Apr 07, Prike Liang wrote: > > The system will be hang up during S3 suspend because of SMU is pending > > for GC not respose the register CP_HQD_ACTIVE access request.This > > issue root cause of accessing the GC register under enter GFX CGGPG > > and can be fixed by disable GFX CGPG before perform suspend. > > > > v2: Use disable the GFX CGPG instead of RLC safe mode guard. > > > > Signed-off-by: Prike Liang <Prike.Liang@xxxxxxx> > > Tested-by: Mengbing Wang <Mengbing.Wang@xxxxxxx> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > index 2e1f955..bf8735b 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > @@ -2440,8 +2440,6 @@ static int > > amdgpu_device_ip_suspend_phase1(struct amdgpu_device *adev) { > > int i, r; > > > > - amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE); > > - amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE); > > > > for (i = adev->num_ip_blocks - 1; i >= 0; i--) { > > if (!adev->ip_blocks[i].status.valid) > > @@ -3470,6 +3468,9 @@ int amdgpu_device_suspend(struct drm_device > *dev, bool fbcon) > > } > > } > > > > + amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE); > > + amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE); > > + > > amdgpu_amdkfd_suspend(adev, !fbcon); > > > > amdgpu_ras_suspend(adev); > > > This breaks shutdown/reboot on my system (Dell latitude 5495). > > -- > Regards, > Johannes Hirte _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cxinhui.pan%40amd.com%7Cde6e0578174940b5f29808d7de948b88%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637222601969843248&sdata=quWGElw%2Fo70VJibuZ7%2BzS%2FcHH2OHSDB%2B5uaFPQUf2Os%3D&reserved=0 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx