On 2020-03-30 9:13 a.m., Simon Ser wrote:
On Monday, March 30, 2020 3:11 PM, Kazlauskas, Nicholas <nicholas.kazlauskas@xxxxxxx> wrote:
On 2020-03-30 9:02 a.m., Simon Ser wrote:
On Monday, March 30, 2020 2:59 PM, Kazlauskas, Nicholas nicholas.kazlauskas@xxxxxxx wrote:
We've been doing these checks for position before but I don't think we
really need them. DC should be disabling the cursor when we ask for a
position completely off the screen.
I think that's better than rejecting the commit entirely at least.
I agree DC should be disabling the cursor in this case, however that's
not yet implemented right? I think implementing this feature is
orthogonal and should be done in a separate patch.
This patch simply copies over the cursor checks in the atomic check
function.
It's implemented on DCN but I don't remember if we're doing it on DCE.
I guess the drop can be in a separate patch.
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>
Thanks for the review. I'll try to figure out whether we can drop this
check (from both the atomic check and the other existing check).
Oh, this was actually the checks for crtc_w/crtc_h. Not the x/y, my bad.
We probably can't drop this from here, but we can drop it from
get_cursor_position after this patch - since it's now in the atomic check.
Thanks,
Nicholas Kazlauskas
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
