Looks great, except the note on patch 4 about the commit description text, and perhaps we don't need a period in the title of patch 3. With those fixed, the series is Reviewed-by: Luben Tuikov <luben.tuikov@xxxxxxx> Thank you Andrey. Regards, Luben On 2020-03-26 16:02, Andrey Grodzovsky wrote: > This patchset introduces AQUIRE_MEM packet submission at the begining of each gfx IB > if requested by user mode client. This is helpful in solving issues with cache coherency > during amdgpu_test and Vulkan CTS tests. > > Andrey Grodzovsky (4): > drm/amdgpu: Add new ring callback to insert memory sync > drm/amdgpu: Add AQUIRE_MEM PACKET3 fields defintion > drm/amdgpu: Add mem_sync implementation for all the ASICs. > drm/amdgpu: Add a UAPI flag for user to call mem_sync > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 3 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 27 +++++++++++++++++- > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 16 ++++++++++- > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 16 ++++++++++- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 17 ++++++++++- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 22 ++++++++++++++- > drivers/gpu/drm/amd/amdgpu/nvd.h | 48 ++++++++++++++++++++++++++++++++ > drivers/gpu/drm/amd/amdgpu/soc15d.h | 25 ++++++++++++++++- > include/uapi/drm/amdgpu_drm.h | 4 +++ > 11 files changed, 175 insertions(+), 7 deletions(-) > _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
