RE: [PATCH] drm/amdgpu: disabled fru eeprom access

["Zhang, Hawking" <Hawking.Zhang@xxxxxxx>]

[AMD Official Use Only - Internal Distribution Only]

 

Never mind, I noticed you added the check in amdgpu_fru_get_product_info. Then I think it’s safe to remove the check from amdgpu_fru_read_eeprom. Other than that, the patch is

 

Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>

 

Regards,
Hawking

 

From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Zhang, Hawking
Sent: Monday, March 23, 2020 17:09
To: Clements, John <John.Clements@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: RE: [PATCH] drm/amdgpu: disabled fru eeprom access

 

[AMD Official Use Only - Internal Distribution Only]

 

Hi John,

 

How about adding the shell function at the beginning of amdgpu_fru_get_product_info. It make sense to me to check the FRU eeprom availability before access. But having the check in amdgpu_fru_read_eeprom would results to unnecessary drm error message for all the following access in amdgpu_fru_get_product_info.

 

Regards,
Hawking

From: Clements, John <John.Clements@xxxxxxx>
Sent: Monday, March 23, 2020 16:51
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Zhang, Hawking <Hawking.Zhang@xxxxxxx>
Subject: [PATCH] drm/amdgpu: disabled fru eeprom access

 

[AMD Official Use Only - Internal Distribution Only]

 

Submitting patch to:

• Disable FRU EEPROM access by default
• Add shell function to be used for supported device detection

 

Thank you,

John Clements

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx