Re: [PATCH v3 3/4] drm/amdgpu: change hw sched list on ctx priority override

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+
+    switch (hw_ip) {
+    case AMDGPU_HW_IP_COMPUTE:
+        compute_priority =
+ amdgpu_ctx_sched_prio_to_compute_prio(priority);
+        scheds = adev->gfx.compute_prio_sched[compute_priority];
+        num_scheds = adev->gfx.num_compute_sched[compute_priority];
+        break;
+    default:
+        return;
+    }
+
+    drm_sched_entity_modify_sched(&aentity->entity, scheds, num_scheds);

That needs to be under the "case AMDGPU_HW_IP_COMPUTE" or otherwise we set the schedulers to NULL for SDMA.
SDMA will fall into  default case which will return from the function immediately.

Oh, that's a bad idea. We still want the call to drm_sched_entity_set_priority() in this case.

Maybe move the call to drm_sched_entity_set_priority() above the switch?
Right we still need drm_sched_entity_set_priority(). I will update it.


Regards,

Nirmoy

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux