On Wed, Feb 26, 2020 at 6:16 PM Matt Coffin <mcoffin13@xxxxxxxxx> wrote: > > Sorry for the extra email, but the mutex_init got lost when I was rebasing. Oops. > > This patchset adds a message lock to lock access to the SMU message > communication registers to prevent concurrent access. > > v2: Separate navi10 change out into a separate patch, and remove mutex > definition from first patch > > v3: Re-add mutex_init to amdgpu_smu.c. It got lost in the rebase > > For Alex's concerns, I omitted one of them, though I can re-submit if > it's still desired. since smu_send_smc_msg was previously around, and is > used in lots of places, I left it alone rather than replace every > occurance as it still makes sense to be able to safely send messages > without arguments, without knowing that the default argument should be > zero. I've tested and applied the patches. I'll get the team to do some more testing across more asics as well. Thanks! BTW, I think you had another change to clean up some of the navi10 code, care to send that one out too? Alex > > Matt Coffin (3): > drm/amdgpu/powerplay: Refactor SMU message handling for safety > drm/amdgpu/powerplay: Remove deprecated smc_read_arg > drm/amdgpu/smu: Add message sending lock > > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 47 ++----- > drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 30 +++-- > .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 4 +- > drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h | 5 +- > drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h | 5 +- > drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 35 ++--- > drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 26 ++-- > drivers/gpu/drm/amd/powerplay/smu_internal.h | 11 +- > drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 120 +++++++++--------- > drivers/gpu/drm/amd/powerplay/smu_v12_0.c | 87 +++++++------ > drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 69 ++++++---- > 11 files changed, 220 insertions(+), 219 deletions(-) > > -- > 2.25.0 > _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
