Hi Christian Thanks a lot for your review Hi Alex Can you help to review it? Thanks in advance. Best Regards Yintian Tao -----Original Message----- From: Koenig, Christian <Christian.Koenig@xxxxxxx> Sent: 2020年2月27日 22:18 To: Tao, Yintian <Yintian.Tao@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH] drm/amdgpu: miss to remove pp_sclk file Am 27.02.20 um 15:11 schrieb Yintian Tao: > Miss to remove pp_sclk file > > Signed-off-by: Yintian Tao <yttao@xxxxxxx> Looks reasonable to me, but Alex can probably better judge. Acked-by: Christian König <christian.koenig@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > index 9deff8cc9723..a43fc1c8ffd0 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > @@ -3471,6 +3471,7 @@ void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev) > device_remove_file(adev->dev, &dev_attr_pp_cur_state); > device_remove_file(adev->dev, &dev_attr_pp_force_state); > device_remove_file(adev->dev, &dev_attr_pp_table); > + device_remove_file(adev->dev, &dev_attr_pp_sclk); > > device_remove_file(adev->dev, &dev_attr_pp_dpm_sclk); > device_remove_file(adev->dev, &dev_attr_pp_dpm_mclk); _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx