Re: [PATCH] drm/amd/amdgpu: disable GFXOFF around debugfs access to MMIO

[Huang Rui <ray.huang@xxxxxxx>]

On Wed, Feb 19, 2020 at 10:09:46AM -0500, Tom St Denis wrote:
> I got some messages after a while:
> 
> [  741.788564] Failed to send Message 8.
> [  746.671509] Failed to send Message 8.
> [  748.749673] Failed to send Message 2b.
> [  759.245414] Failed to send Message 7.
> [  763.216902] Failed to send Message 2a.
> 
> Are there any additional locks that should be held?  Because some commands
> like --top or --waves can do a lot of distinct read operations (causing a
> lot of enable/disable calls).
> 
> I'm going to sit on this a bit since I don't think the patch is ready for
> pushing out.
> 

How about use RREG32_KIQ and WREG32_KIQ?

Thanks,
Ray

> 
> Tom
> 
> On 2020-02-19 10:07 a.m., Alex Deucher wrote:
> > On Wed, Feb 19, 2020 at 10:04 AM Tom St Denis <tom.stdenis@xxxxxxx> wrote:
> > > Signed-off-by: Tom St Denis <tom.stdenis@xxxxxxx>
> > Please add a patch description.  With that fixed:
> > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
> > 
> > > ---
> > >   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3 +++
> > >   1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > > index 7379910790c9..66f763300c96 100644
> > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > > @@ -169,6 +169,7 @@ static int  amdgpu_debugfs_process_reg_op(bool read, struct file *f,
> > >          if (pm_pg_lock)
> > >                  mutex_lock(&adev->pm.mutex);
> > > 
> > > +       amdgpu_gfx_off_ctrl(adev, false);
> > >          while (size) {
> > >                  uint32_t value;
> > > 
> > > @@ -192,6 +193,8 @@ static int  amdgpu_debugfs_process_reg_op(bool read, struct file *f,
> > >          }
> > > 
> > >   end:
> > > +       amdgpu_gfx_off_ctrl(adev, true);
> > > +
> > >          if (use_bank) {
> > >                  amdgpu_gfx_select_se_sh(adev, 0xffffffff, 0xffffffff, 0xffffffff);
> > >                  mutex_unlock(&adev->grbm_idx_mutex);
> > > --
> > > 2.24.1
> > > 
> > > _______________________________________________
> > > amd-gfx mailing list
> > > amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cray.huang%40amd.com%7C7db7d3365c8842d46cde08d7b54dc560%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637177217984125436&amp;sdata=NBNxMQ%2Fuq7YswVzlrvZWbSmcf4JUt4eL5L62%2F7iLL28%3D&amp;reserved=0
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cray.huang%40amd.com%7C7db7d3365c8842d46cde08d7b54dc560%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637177217984125436&amp;sdata=NBNxMQ%2Fuq7YswVzlrvZWbSmcf4JUt4eL5L62%2F7iLL28%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx