> + if (!entity->rq) > + return 0; > + Yes, supposedly we shouldn't get 'entity->rq == NULL' case , that looks the true bug -----邮件原件----- 发件人: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> 代表 Christian K?nig 发送时间: 2020年2月19日 18:50 收件人: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Li, Dennis <Dennis.Li@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Zhou1, Tao <Tao.Zhou1@xxxxxxx>; Chen, Guchun <Guchun.Chen@xxxxxxx> 主题: Re: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference Well of hand this patch looks like a clear NAK to me. Returning without raising an error is certainly the wrong thing to do here because we just drop the necessary page table updates. How does the entity->rq ends up as NULL in the first place? Regards, Christian. Am 19.02.20 um 07:26 schrieb Zhang, Hawking: > [AMD Official Use Only - Internal Distribution Only] > > Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx> > > Regards, > Hawking > -----Original Message----- > From: Dennis Li <Dennis.Li@xxxxxxx> > Sent: Wednesday, February 19, 2020 12:05 > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander > <Alexander.Deucher@xxxxxxx>; Zhou1, Tao <Tao.Zhou1@xxxxxxx>; Zhang, > Hawking <Hawking.Zhang@xxxxxxx>; Chen, Guchun <Guchun.Chen@xxxxxxx> > Cc: Li, Dennis <Dennis.Li@xxxxxxx> > Subject: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference > > check whether the queue of entity is null to avoid null pointer dereference. > > Change-Id: I08d56774012cf229ba2fe7a011c1359e8d1e2781 > Signed-off-by: Dennis Li <Dennis.Li@xxxxxxx> > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c > index 4cc7881f438c..67cca463ddcc 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c > @@ -95,6 +95,9 @@ static int amdgpu_vm_sdma_commit(struct amdgpu_vm_update_params *p, > int r; > > entity = p->direct ? &p->vm->direct : &p->vm->delayed; > + if (!entity->rq) > + return 0; > + > ring = container_of(entity->rq->sched, struct amdgpu_ring, sched); > > WARN_ON(ib->length_dw == 0); > -- > 2.17.1 > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist > s.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cmo > nk.liu%40amd.com%7C28e7260af3a24eec758f08d7b52975e3%7C3dd8961fe4884e60 > 8e11a82d994e183d%7C0%7C0%7C637177062003213431&sdata=vMXmhwTlN8lAav > uqhYhpmKLM6V%2F%2B2%2FubFBbsk%2BGY%2Bjw%3D&reserved=0 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cmonk.liu%40amd.com%7C28e7260af3a24eec758f08d7b52975e3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637177062003213431&sdata=vMXmhwTlN8lAavuqhYhpmKLM6V%2F%2B2%2FubFBbsk%2BGY%2Bjw%3D&reserved=0 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
