Looks fine to me as well. Just as Christian said, would have to be approved by Marek. Regards, Luben On 2020-02-11 9:57 a.m., Deucher, Alexander wrote: > Yes, correct. > > Alex > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > *From:* Huang, Ray <Ray.Huang@xxxxxxx> > *Sent:* Tuesday, February 11, 2020 9:35 AM > *To:* Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Christian König <ckoenig.leichtzumerken@xxxxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> > *Cc:* Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer@xxxxxxx>; Olsak, Marek <Marek.Olsak@xxxxxxx>; Liu, Aaron <Aaron.Liu@xxxxxxx>; Tuikov, Luben <Luben.Tuikov@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx> > *Subject:* RE: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests > > > [AMD Public Use] > > > > Hi Alex, > > > > MR = merge request? Should I create account to send merge request in the freedesktop gitlab? > > > > Thanks, > > Ray > > > > *From:* Deucher, Alexander <Alexander.Deucher@xxxxxxx> > *Sent:* Tuesday, February 11, 2020 10:30 PM > *To:* Christian König <ckoenig.leichtzumerken@xxxxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > *Cc:* Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer@xxxxxxx>; Olsak, Marek <Marek.Olsak@xxxxxxx>; Liu, Aaron <Aaron.Liu@xxxxxxx>; Tuikov, Luben <Luben.Tuikov@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx> > *Subject:* Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests > > > > [AMD Public Use] > > > > Also, libdrm changes should go through a gitlab MR now. > > > > Alex > > > > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > > *From:*Christian König <ckoenig.leichtzumerken@xxxxxxxxx <mailto:ckoenig.leichtzumerken@xxxxxxxxx>> > *Sent:* Tuesday, February 11, 2020 6:39 AM > *To:* Huang, Ray <Ray.Huang@xxxxxxx <mailto:Ray.Huang@xxxxxxx>>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <mailto:amd-gfx@xxxxxxxxxxxxxxxxxxxxx><amd-gfx@xxxxxxxxxxxxxxxxxxxxx <mailto:amd-gfx@xxxxxxxxxxxxxxxxxxxxx>> > *Cc:* Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer@xxxxxxx <mailto:Pierre-eric.Pelloux-prayer@xxxxxxx>>; Olsak, Marek <Marek.Olsak@xxxxxxx <mailto:Marek.Olsak@xxxxxxx>>; Liu, Aaron <Aaron.Liu@xxxxxxx <mailto:Aaron.Liu@xxxxxxx>>; Tuikov, Luben <Luben.Tuikov@xxxxxxx <mailto:Luben.Tuikov@xxxxxxx>>; Deucher, Alexander <Alexander.Deucher@xxxxxxx <mailto:Alexander.Deucher@xxxxxxx>>; Koenig, Christian <Christian.Koenig@xxxxxxx <mailto:Christian.Koenig@xxxxxxx>> > *Subject:* Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests > > > > Looks good on first glance, but Marek and/or Pierre can probably better > judge than me. > > Christian. > > Am 11.02.20 um 12:22 schrieb Huang Rui: >> So far, the amdgpu_cs_submit_raw2 is used for MesaGL, however the amdgpu tests >> still use the legacy interface. So we would like to make amdgpu tests verify the >> amdgpu_cs_submit_raw2 API. >> >> Thanks, >> Ray >> >> Huang Rui (4): >> amdgpu: use alloca for dependencies and sem_dependencies >> amdgpu: use amdgpu_cs_submit_raw2 in amdgpu_cs_submit >> amdgpu: remove the un-used chunk_array >> amdgpu: clean up the cs structure variable >> >> amdgpu/amdgpu_cs.c | 36 +++++++++++++----------------------- >> 1 file changed, 13 insertions(+), 23 deletions(-) >> > _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
