Re: [PATCH] amdgpu: Prevent build errors regarding soft/hard-float FP ABI tags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 6, 2020 at 2:21 PM Daniel Kolesa <daniel@xxxxxxxxxxxxx> wrote:
>
> On PowerPC, the compiler will tag object files with whether they
> use hard or soft float FP ABI and whether they use 64 or 128-bit
> long double ABI. On systems with 64-bit long double ABI, a tag
> will get emitted whenever a double is used, as on those systems
> a long double is the same as a double. This will prevent linkage
> as other files are being compiled with hard-float.
>
> On ppc64, this code will never actually get used for the time
> being, as the only currently existing hardware using it are the
> Renoir APUs. Therefore, until this is testable and can be fixed
> properly, at least make sure the build will not fail.
>
> Signed-off-by: Daniel Kolesa <daniel@xxxxxxxxxxxxx>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/clk_mgr/Makefile | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/Makefile b/drivers/gpu/drm/amd/display/dc/clk_mgr/Makefile
> index b864869..6fa7422 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/Makefile
> @@ -91,6 +91,12 @@ ifdef CONFIG_DRM_AMD_DC_DCN2_1
>  ###############################################################################
>  CLK_MGR_DCN21 = rn_clk_mgr.o rn_clk_mgr_vbios_smu.o
>
> +# prevent build errors regarding soft-float vs hard-float FP ABI tags
> +# this code is currently unused on ppc64, as it applies to Renoir APUs only
> +ifdef CONFIG_PPC64
> +CFLAGS_$(AMDDALPATH)/dc/clk_mgr/dcn21/rn_clk_mgr.o := $(call cc-option,-mno-gnu-attribute)
> +endif
> +
>  AMD_DAL_CLK_MGR_DCN21 = $(addprefix $(AMDDALPATH)/dc/clk_mgr/dcn21/,$(CLK_MGR_DCN21))
>
>  AMD_DISPLAY_FILES += $(AMD_DAL_CLK_MGR_DCN21)
> --
> 2.25.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux