On Thu, 28 Nov 2019 15:35:23 +0100,
Harry Wentland wrote:
>
> On 2019-11-28 3:27 a.m., Takashi Iwai wrote:
> > Currently, gcc spews a warning as:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubbub.c: In function ‘hubbub1_verify_allow_pstate_change_high’:
> > ./include/drm/drm_print.h:316:2: warning: ‘debug_data’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> >
> > This is because the code checks against a static value although it's
> > basically a constant and guaranteed to be set.
> >
> > This patch changes the type prefix from static to const for addressing
> > the compile warning above and also for letting the compiler optimize
> > better.
> >
> > Fixes: 62d591a8e00c ("drm/amd/display: create new files for hubbub functions")
> > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
>
> Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>
>
> Harry
This patch seems forgotten? The compile warning is still present in
the latest for-next.
thanks,
Takashi
>
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c
> > index a02c10e23e0d..b5c44c3bdb98 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c
> > @@ -128,8 +128,8 @@ bool hubbub1_verify_allow_pstate_change_high(
> > * pstate takes around ~100us on linux. Unknown currently as to
> > * why it takes that long on linux
> > */
> > - static unsigned int pstate_wait_timeout_us = 200;
> > - static unsigned int pstate_wait_expected_timeout_us = 40;
> > + const unsigned int pstate_wait_timeout_us = 200;
> > + const unsigned int pstate_wait_expected_timeout_us = 40;
> > static unsigned int max_sampled_pstate_wait_us; /* data collection */
> > static bool forced_pstate_allow; /* help with revert wa */
> >
> >
>
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
