Re: [PATCH 1/5] drm/amdgpu: fix braces in amdgpu_vm_update_ptes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 30.01.20 um 23:11 schrieb Felix Kuehling:

On 2020-01-30 7:49, Christian König wrote:
For the root PD mask can be 0xffffffff as well which would
overrun to 0 if we don't cast it before we add one.
You're fixing parentheses, not braces.

Parentheses: ()
Brackets: []
Braces: {}

Yeah, I can't remember which is what in English. Need to double check that next time.


With the title fixed, this patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>

Thanks for the review,
Christian.



Signed-off-by: Christian König <christian.koenig@xxxxxxx>
Tested-by: Tom St Denis <tom.stdenis@xxxxxxx>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 5cb182231f5d..4ba6a5e5d094 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1487,7 +1487,7 @@ static int amdgpu_vm_update_ptes(struct amdgpu_vm_update_params *params,
          incr = (uint64_t)AMDGPU_GPU_PAGE_SIZE << shift;
          mask = amdgpu_vm_entries_mask(adev, cursor.level);
          pe_start = ((cursor.pfn >> shift) & mask) * 8;
-        entry_end = (uint64_t)(mask + 1) << shift;
+        entry_end = ((uint64_t)mask + 1) << shift;
          entry_end += cursor.pfn & ~(entry_end - 1);
          entry_end = min(entry_end, end);

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux