On Tue, Jan 28, 2020 at 1:49 PM Matt Coffin <mcoffin13@xxxxxxxxx> wrote: > > > > On 1/28/20 10:26 AM, Alex Deucher wrote: > > On Tue, Jan 28, 2020 at 11:44 AM Matt Coffin <mcoffin13@xxxxxxxxx> wrote: > > > I just copied that vega20 did. You may be right. I haven't paged the > > recent SMU interface stuff into my head in a while. If so, we should > > also fix the vega20_ppt.c code. > > The vega20_ppt code was correct, until we implemented the ability for > the user to write to that overdrive table, which will land in 5.5. > > Not entirely sure about the canonical way to distribute changes to > someone else's series, but I can take a crack at fixing this. > Thanks. Just go ahead and send patches. Alex > >> > >> On 1/25/20 11:48 AM, Alex Deucher wrote: > >>> Was missing before. > >>> > >>> Bug: https://gitlab.freedesktop.org/drm/amd/issues/1020 > >>> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > >>> --- > >>> drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 8 ++++++++ > >>> 1 file changed, 8 insertions(+) > >>> > >>> diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c > >>> index d2d45181ae23..f60762f9b143 100644 > >>> --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c > >>> +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c > >>> @@ -2062,6 +2062,14 @@ static int navi10_od_edit_dpm_table(struct smu_context *smu, enum PP_OD_DPM_TABL > >>> if (ret) > >>> return ret; > >>> od_table->UclkFmax = input[1]; > >>> + break; > >>> + case PP_OD_RESTORE_DEFAULT_TABLE: > >>> + ret = smu_update_table(smu, SMU_TABLE_OVERDRIVE, 0, table_context->overdrive_table, false); > >>> + if (ret) { > >>> + pr_err("Failed to export over drive table!\n"); > >>> + return ret; > >>> + } > >>> + > >>> break; > >>> case PP_OD_COMMIT_DPM_TABLE: > >>> navi10_dump_od_table(od_table); > >>> _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
