On Wed, Jan 22, 2020 at 11:12 AM Harry Wentland <hwentlan@xxxxxxx> wrote: > > On 2020-01-16 3:29 p.m., Bhawanpreet Lakha wrote: > > These patches adds support for SRM loading. By providing an interface to the > > usermode > > > > SRM has to be persistent and since the kernel cannot directly write to system > > storage we need to provide an interface so that the usermode can do it for us > > > > We'll want to elaborate a bit more on why and how this is done. As > mentioned on my patch 2 comments I recommend to do this there as the > cover letter is lost after merge. > You might also want to cc dri-devel if you resend to get more reviews. I'm also not crazy about having to update the file in chunks, but I don't have any better ideas off hand. Maybe an ioctl would be cleaner? Alex > Harry > > > > > Bhawanpreet Lakha (5): > > drm/amd/display: Pass amdgpu_device instead of psp_context > > drm/amd/display: update psp interface header > > drm/amd/display: Add sysfs interface for set/get srm > > drm/amd/display: Load srm before enabling HDCP > > drm/amd/display: call psp set/get interfaces > > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > > .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 182 +++++++++++++++++- > > .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.h | 9 +- > > .../drm/amd/display/modules/hdcp/hdcp_psp.h | 26 ++- > > 4 files changed, 212 insertions(+), 7 deletions(-) > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx