Re: [PATCH 1/8] drm/amdgpu: drop amdgpu_job.owner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I replied with one question about patch 4. Other than that the series is

Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>

On 2020-01-13 9:40 a.m., Christian König wrote:
Entirely unused.

Signed-off-by: Christian König <christian.koenig@xxxxxxx>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c  | 1 -
  drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 1 -
  drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 1 -
  3 files changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index 614919f265b9..c4a8148b9b6f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@ -1233,7 +1233,6 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
  		goto error_abort;
  	}
- job->owner = p->filp;
  	p->fence = dma_fence_get(&job->base.s_fence->finished);
amdgpu_ctx_add_fence(p->ctx, entity, p->fence, &seq);
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
index 73328d0c741d..d42be880a236 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
@@ -153,7 +153,6 @@ int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
  	if (r)
  		return r;
- job->owner = owner;
  	*f = dma_fence_get(&job->base.s_fence->finished);
  	amdgpu_job_free_resources(job);
  	priority = job->base.s_priority;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h
index aa0e375062f2..31c4444b0203 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h
@@ -49,7 +49,6 @@ struct amdgpu_job {
  	uint32_t		preamble_status;
  	uint32_t                preemption_status;
  	uint32_t		num_ibs;
-	void			*owner;
  	bool                    vm_needs_flush;
  	uint64_t		vm_pd_addr;
  	unsigned		vmid;
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux