RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[AMD Public Use]

 

Thanks John.

 

+            for (retry_loop = 0; retry_loop < 10; retry_loop++)

+            {

The same coding style problem that “{” should not start at one new line. With this fixed, the patch is:

Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx>

 

Regards,

Guchun

 

From: Clements, John <John.Clements@xxxxxxx>
Sent: Friday, January 3, 2020 4:13 PM
To: Chen, Guchun <Guchun.Chen@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability

 

[AMD Official Use Only - Internal Distribution Only]

 

Hello GuChun,

 

I have updated the patch with your suggestion, and added back in the delay.

 

I can potentially investigate its removal in another patch

 

Thank you,

John Clements

 

From: Chen, Guchun <Guchun.Chen@xxxxxxx>
Sent: Friday, January 3, 2020 3:44 PM
To: Clements, John <John.Clements@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability

 

[AMD Official Use Only - Internal Distribution Only]

 

-             /* there might be handshake issue with hardware which needs delay */

-             mdelay(20);

 

To be safety, I don’t think we should remove this delay. And this actually do nothing with the code refine in this patch.

 

Regards,

Guchun

 

From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Clements, John
Sent: Friday, January 3, 2020 3:29 PM
To: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: [PATCH] drm/amdgpu: added function to wait for PSP BL availability

 

[AMD Official Use Only - Internal Distribution Only]

 

Added dedicated function to wait for PSP BL availability.

 

Increased driver wait time for PSP BL availability.

 

Thank you,

John Clements

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux