[AMD Official Use Only - Internal Distribution Only] Hello Guchun, Thank you for your feedback, I have updated the indentations to make them consistent. I am not so sure if the psp_ta_invoke function should be a static function. As the Linux TA count grows, we may want to split up amdgpu_psp.c to leverage the psp_ta_invoke function from other TA dedicated source file. Thank you, John Clements From: Chen, Guchun <Guchun.Chen@xxxxxxx> [AMD Official Use Only - Internal Distribution Only] In patch 3, 1. psp_ta_invoke should be one static function? 2. The indentation in each “return” line looks not correct. With above fixed, series is: Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx>. From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx>
On Behalf Of Clements, John [AMD Official Use Only - Internal Distribution Only] Patch 1:
Patch 2:
Patch 3:
Thank you, John Clements |
Attachment:
0003-drm-amdgpu-amalgamated-PSP-TA-invoke-functions.patch
Description: 0003-drm-amdgpu-amalgamated-PSP-TA-invoke-functions.patch
Attachment:
0001-drm-amdgpu-by-default-output-PSP-ret-status-in-event-.patch
Description: 0001-drm-amdgpu-by-default-output-PSP-ret-status-in-event-.patch
Attachment:
0002-drm-amdgpu-amalgamate-PSP-TA-load-unload-functions.patch
Description: 0002-drm-amdgpu-amalgamate-PSP-TA-load-unload-functions.patch
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx