On Wed, Dec 18, 2019 at 3:13 AM Pan Zhang <zhangpan26@xxxxxxxxxx> wrote: > > this set adds support for removal of gpu drm dead code. > > patch1: > `num` is a data of u8 type and ATOM_MAX_HW_I2C_READ == 255, > > so there is a impossible condition '(num > 255) => (0-255 > 255)'. > > Signed-off-by: Pan Zhang <zhangpan26@xxxxxxxxxx> This change was already made by someone else. Alex > --- > drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c > index 980c363..b4cc7c5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c > +++ b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c > @@ -76,11 +76,6 @@ static int amdgpu_atombios_i2c_process_i2c_ch(struct amdgpu_i2c_chan *chan, > } > args.lpI2CDataOut = cpu_to_le16(out); > } else { > - if (num > ATOM_MAX_HW_I2C_READ) { > - DRM_ERROR("hw i2c: tried to read too many bytes (%d vs 255)\n", num); > - r = -EINVAL; > - goto done; > - } > args.ucRegIndex = 0; > args.lpI2CDataOut = 0; > } > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx