[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Emily Deng <Emily.Deng@xxxxxxx> >-----Original Message----- >From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Monk Liu >Sent: Tuesday, December 17, 2019 6:20 PM >To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx >Cc: Liu, Monk <Monk.Liu@xxxxxxx> >Subject: [PATCH 2/2] drm/amdgpu: fix KIQ ring test fail in TDR of SRIOV > >issues: >MEC is ruined by the amdkfd_pre_reset after VF FLR done > >fix: >amdkfd_pre_reset() would ruin MEC after hypervisor finished the VF FLR, the >correct sequence is do amdkfd_pre_reset before VF FLR but there is a limitation >to block this sequence: >if we do pre_reset() before VF FLR, it would go KIQ way to do register access and >stuck there, because KIQ probably won't work by that time (e.g. you already >made GFX hang) > >so the best way right now is to simply remove it. > >Signed-off-by: Monk Liu <Monk.Liu@xxxxxxx> >--- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >index 605cef6..ae962b9 100644 >--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >@@ -3672,8 +3672,6 @@ static int amdgpu_device_reset_sriov(struct >amdgpu_device *adev, > if (r) > return r; > >- amdgpu_amdkfd_pre_reset(adev); >- > /* Resume IP prior to SMC */ > r = amdgpu_device_ip_reinit_early_sriov(adev); > if (r) >-- >2.7.4 > >_______________________________________________ >amd-gfx mailing list >amd-gfx@xxxxxxxxxxxxxxxxxxxxx >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fre >edesktop.org%2Fmailman%2Flistinfo%2Famd- >gfx&data=02%7C01%7CEmily.Deng%40amd.com%7C74408803b49e4f328 >f7708d782daba6c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6 >37121748318124859&sdata=4YbyHwEEGxVLEhuOg%2Frc%2FxdhFRwrdm >FuZ4vpHx%2FApAE%3D&reserved=0 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
