Re: [PATCH] drm/amd/powerplay: clear VBIOS scratchs on baco exit

["Yuan, Xiaojie" <Xiaojie.Yuan@xxxxxxx>]

Hi Evan,

Just out of curiosity, may I know what issue are you trying to fix?
I used to see vbios post failure (hangs in atombios init table) after baco exit occasionally on navi.

BR,
Xiaojie

> On Dec 6, 2019, at 11:37 AM, Evan Quan <evan.quan@xxxxxxx> wrote:
> 
> This is needed for coming asic init on performing gpu reset.
> 
> Change-Id: If3671a24d239e3d288665fadaa2c40c87d5da40b
> Signed-off-by: Evan Quan <evan.quan@xxxxxxx>
> ---
> drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> index 39ec06aee809..ab809df7bc35 100644
> --- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> +++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> @@ -1659,6 +1659,12 @@ int smu_v11_0_baco_set_state(struct smu_context *smu, enum smu_baco_state state)
>        }
>    } else {
>        ret = smu_send_smc_msg(smu, SMU_MSG_ExitBaco);
> +        if (ret)
> +            goto out;
> +
> +        WREG32_SOC15(NBIO, 0, mmBIOS_SCRATCH_6, 0);
> +        WREG32_SOC15(NBIO, 0, mmBIOS_SCRATCH_7, 0);
> +
>        bif_doorbell_intr_cntl = REG_SET_FIELD(bif_doorbell_intr_cntl,
>                        BIF_DOORBELL_INT_CNTL,
>                        DOORBELL_INTERRUPT_DISABLE, 0);
> -- 
> 2.24.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7CXiaojie.Yuan%40amd.com%7C682c142ef30748bbd00508d779fd6f82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637112002208927733&amp;sdata=bajaaj3Cw2IxW5nRucg3FXUjcyIi50kCSPQ7eknqk4o%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx