> -----Original Message----- > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Sent: Friday, November 29, 2019 11:09 PM > To: Lin, Wayne <Wayne.Lin@xxxxxxx> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH V2 1/2] drm/edid: Add aspect ratios to HDMI 4K modes > > On Mon, Nov 18, 2019 at 06:18:31PM +0800, Wayne Lin wrote: > > [Why] > > HDMI 2.0 adds aspect ratio attribute to distinguish different 4k > > modes. According to Appendix E of HDMI 2.0 spec, source should use > > VSIF to indicate video mode only when the mode is one defined in HDMI > > 1.4b 4K modes. Otherwise, use AVI infoframes to convey VIC. > > > > Current code doesn't take aspect ratio into consideration while > > constructing avi infoframe. Should modify that. > > > > [How] > > Inherit Ville Syrjälä's work > > "drm/edid: Prep for HDMI VIC aspect ratio" at > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > > hwork.kernel.org%2Fpatch%2F11174639%2F&data=02%7C01%7CWayne.L > in%40 > > > amd.com%7C1fbbc9d617234af5f3d408d774de0a7c%7C3dd8961fe4884e608e1 > 1a82d9 > > > 94e183d%7C0%7C0%7C637106369315352334&sdata=QPW9CnwgPkl2DIn > bymfaYT% > > 2F6jxdmVaTMKEMN69VBFcQ%3D&reserved=0 > > > > Add picture_aspect_ratio attributes to edid_4k_modes[] and construct > > VIC and HDMI_VIC by taking aspect ratio into consideration. > > > > v2: Correct missing initializer error at adding aspect ratio of SMPTE > > mode. > > > > Signed-off-by: Wayne Lin <Wayne.Lin@xxxxxxx> > > Our CI didn't complain about anything that looked relevant, so I went ahead an > pushed these to drm-misc-next. > > Thanks for the patches. Many thanks for your time. > > -- > Ville Syrjälä > Intel -- Regards, Wayne Lin _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
