[AMD Official Use Only - Internal Distribution Only] I don't think you need to introduce SRIOV specific path here. The gfx_v10_0_init_pg should be good enough to cover both bare-metal and virtualization case. You can drop the tlb flush in that function if that's your major concern. Regards, Hawking -----Original Message----- From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Monk Liu Sent: 2019年11月29日 16:24 To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Liu, Monk <Monk.Liu@xxxxxxx> Subject: [PATCH 1/2] drm/amdgpu: fix GFX10 missing CSIB set still need to init csb even for SRIOV Signed-off-by: Monk Liu <Monk.Liu@xxxxxxx> --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index 74edfd9..230e8af 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c @@ -1874,14 +1874,16 @@ static int gfx_v10_0_rlc_resume(struct amdgpu_device *adev) { int r; - if (amdgpu_sriov_vf(adev)) - return 0; - if (adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) { r = gfx_v10_0_wait_for_rlc_autoload_complete(adev); if (r) return r; + if (amdgpu_sriov_vf(adev)) { + gfx_v10_0_init_csb(adev); + return 0; + } + r = gfx_v10_0_init_pg(adev); if (r) return r; -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Chawking.zhang%40amd.com%7Cc343afa9aa234cbb827508d774a57268%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637106127277353086&sdata=Kt%2Fd1680Rc3lyFwz4ng5eA7JxiYWjf1whDBpfnHzTJs%3D&reserved=0 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx