RE: [PATCH 10/10 v2] drm/amdgpu: reduce redundant uvd context lost warning message

"Ma, Le" <Le.Ma@xxxxxxx> · Wed, 27 Nov 2019 10:39:12 +0000

-----Original Message-----

From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx> 

Sent: Wednesday, November 27, 2019 6:08 PM

To: Ma, Le <Le.Ma@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx

Cc: Chen, Guchun <Guchun.Chen@xxxxxxx>; Zhou1, Tao <Tao.Zhou1@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Li, Dennis <Dennis.Li@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>

Subject: Re: [PATCH 10/10 v2] drm/amdgpu: reduce redundant uvd context lost warning message

Am 27.11.19 um 11:02 schrieb Le Ma:
> Move the print out of uvd instance loop in amdgpu_uvd_suspend
> 
> v2: drop unnecessary brackets
> 
> Change-Id: Ifad997debd84763e1b55d668e144b729598f115e
> Signed-off-by: Le Ma <le.ma@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c 

> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> index e324bfe..69248ecb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> @@ -376,13 +376,15 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev)
>                                  return -ENOMEM;
>   
>                      /* re-write 0 since err_event_athub will corrupt VCPU buffer */
> -                   if (amdgpu_ras_intr_triggered()) {
> -                               DRM_WARN("UVD VCPU state may lost due to RAS ERREVENT_ATHUB_INTERRUPT\n");
> +                  if (amdgpu_ras_intr_triggered())

Can the state change while doing the loop? If yes than I would rather grab that once and use it multiple times.

Christian.

[Le]: Got your meaning, and the state will not change here. Will update this in v3.

>                                  memset(adev->uvd.inst[j].saved_bo, 0, size);
> -                   } else {
> +                  else
>                                  memcpy_fromio(adev->uvd.inst[j].saved_bo, ptr, size);
> -                   }
>          }
> +
> +      if (amdgpu_ras_intr_triggered())
> +                  DRM_WARN("UVD VCPU state may lost due to RAS

> +ERREVENT_ATHUB_INTERRUPT\n");
> +
>          return 0;
>   }
>   

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx