Applied. thanks! Alex On Thu, Nov 21, 2019 at 11:54 AM Colin King <colin.king@xxxxxxxxxxxxx> wrote: > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The pointer write_frame is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > index 2a8a08aa6eaf..c02f9ffe5c6b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > @@ -1728,7 +1728,7 @@ int psp_ring_cmd_submit(struct psp_context *psp, > int index) > { > unsigned int psp_write_ptr_reg = 0; > - struct psp_gfx_rb_frame *write_frame = psp->km_ring.ring_mem; > + struct psp_gfx_rb_frame *write_frame; > struct psp_ring *ring = &psp->km_ring; > struct psp_gfx_rb_frame *ring_buffer_start = ring->ring_mem; > struct psp_gfx_rb_frame *ring_buffer_end = ring_buffer_start + > -- > 2.24.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx