Applied. Thanks! Alex On Mon, Nov 18, 2019 at 3:15 AM Quan, Evan <Evan.Quan@xxxxxxx> wrote: > > Reviewed-by: Evan Quan <evan.quan@xxxxxxx> > > > -----Original Message----- > > From: Chen Wandun <chenwandun@xxxxxxxxxx> > > Sent: Monday, November 18, 2019 4:04 PM > > To: Quan, Evan <Evan.Quan@xxxxxxx>; Deucher, Alexander > > <Alexander.Deucher@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Cc: chenwandun@xxxxxxxxxx > > Subject: [PATCH v2] drm/amd/powerplay: return errno code to caller when > > error occur > > > > return errno code to caller when error occur, and meanwhile remove gcc '- > > Wunused-but-set-variable' warning. > > > > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vegam_smumgr.c: In > > function vegam_populate_smc_boot_level: > > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vegam_smumgr.c:1364: > > 6: warning: variable result set but not used [-Wunused-but-set-variable] > > > > Signed-off-by: Chen Wandun <chenwandun@xxxxxxxxxx> > > --- > > drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c > > b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c > > index 2068eb0..50896e9 100644 > > --- a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c > > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c > > @@ -1371,11 +1371,16 @@ static int vegam_populate_smc_boot_level(struct > > pp_hwmgr *hwmgr, > > result = phm_find_boot_level(&(data->dpm_table.sclk_table), > > data->vbios_boot_state.sclk_bootup_value, > > (uint32_t *)&(table->GraphicsBootLevel)); > > + if (result) > > + return result; > > > > result = phm_find_boot_level(&(data->dpm_table.mclk_table), > > data->vbios_boot_state.mclk_bootup_value, > > (uint32_t *)&(table->MemoryBootLevel)); > > > > + if (result) > > + return result; > > + > > table->BootVddc = data->vbios_boot_state.vddc_bootup_value * > > VOLTAGE_SCALE; > > table->BootVddci = data->vbios_boot_state.vddci_bootup_value * > > -- > > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx