On Mon, Nov 18, 2019 at 5:07 AM Hawking Zhang <Hawking.Zhang@xxxxxxx> wrote:
>
> Drop all the IP specific cmd_submit callback function
> and use the common helper instead
>
> Change-Id: I865b26fd25a696f213e888beb927717dec884546
> Signed-off-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>
Nice cleanup!
Series is:
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 5 ---
> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 49 --------------------
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 58 ------------------------
> drivers/gpu/drm/amd/amdgpu/psp_v12_0.c | 58 ------------------------
> drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 60 -------------------------
> 6 files changed, 1 insertion(+), 231 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 225abd42b8de..9e7cfa5e57eb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -156,7 +156,7 @@ psp_cmd_submit_buf(struct psp_context *psp,
> memcpy(psp->cmd_buf_mem, cmd, sizeof(struct psp_gfx_cmd_resp));
>
> index = atomic_inc_return(&psp->fence_value);
> - ret = psp_cmd_submit(psp, psp->cmd_buf_mc_addr, fence_mc_addr, index);
> + ret = psp_ring_cmd_submit(psp, psp->cmd_buf_mc_addr, fence_mc_addr, index);
> if (ret) {
> atomic_dec(&psp->fence_value);
> mutex_unlock(&psp->mutex);
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
> index 482e7675b7da..40594f27dab1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
> @@ -94,9 +94,6 @@ struct psp_funcs
> enum psp_ring_type ring_type);
> int (*ring_destroy)(struct psp_context *psp,
> enum psp_ring_type ring_type);
> - int (*cmd_submit)(struct psp_context *psp,
> - uint64_t cmd_buf_mc_addr, uint64_t fence_mc_addr,
> - int index);
> bool (*compare_sram_data)(struct psp_context *psp,
> struct amdgpu_firmware_info *ucode,
> enum AMDGPU_UCODE_ID ucode_type);
> @@ -302,8 +299,6 @@ struct amdgpu_psp_funcs {
> #define psp_ring_create(psp, type) (psp)->funcs->ring_create((psp), (type))
> #define psp_ring_stop(psp, type) (psp)->funcs->ring_stop((psp), (type))
> #define psp_ring_destroy(psp, type) ((psp)->funcs->ring_destroy((psp), (type)))
> -#define psp_cmd_submit(psp, cmd_mc, fence_mc, index) \
> - (psp)->funcs->cmd_submit((psp), (cmd_mc), (fence_mc), (index))
> #define psp_compare_sram_data(psp, ucode, type) \
> (psp)->funcs->compare_sram_data((psp), (ucode), (type))
> #define psp_init_microcode(psp) \
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> index b8a461d46cb5..e7d56c25b0f8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> @@ -227,54 +227,6 @@ static int psp_v10_0_ring_destroy(struct psp_context *psp,
> return ret;
> }
>
> -static int psp_v10_0_cmd_submit(struct psp_context *psp,
> - uint64_t cmd_buf_mc_addr, uint64_t fence_mc_addr,
> - int index)
> -{
> - unsigned int psp_write_ptr_reg = 0;
> - struct psp_gfx_rb_frame * write_frame = psp->km_ring.ring_mem;
> - struct psp_ring *ring = &psp->km_ring;
> - struct psp_gfx_rb_frame *ring_buffer_start = ring->ring_mem;
> - struct psp_gfx_rb_frame *ring_buffer_end = ring_buffer_start +
> - ring->ring_size / sizeof(struct psp_gfx_rb_frame) - 1;
> - struct amdgpu_device *adev = psp->adev;
> - uint32_t ring_size_dw = ring->ring_size / 4;
> - uint32_t rb_frame_size_dw = sizeof(struct psp_gfx_rb_frame) / 4;
> -
> - /* KM (GPCOM) prepare write pointer */
> - psp_write_ptr_reg = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_67);
> -
> - /* Update KM RB frame pointer to new frame */
> - if ((psp_write_ptr_reg % ring_size_dw) == 0)
> - write_frame = ring_buffer_start;
> - else
> - write_frame = ring_buffer_start + (psp_write_ptr_reg / rb_frame_size_dw);
> - /* Check invalid write_frame ptr address */
> - if ((write_frame < ring_buffer_start) || (ring_buffer_end < write_frame)) {
> - DRM_ERROR("ring_buffer_start = %p; ring_buffer_end = %p; write_frame = %p\n",
> - ring_buffer_start, ring_buffer_end, write_frame);
> - DRM_ERROR("write_frame is pointing to address out of bounds\n");
> - return -EINVAL;
> - }
> -
> - /* Initialize KM RB frame */
> - memset(write_frame, 0, sizeof(struct psp_gfx_rb_frame));
> -
> - /* Update KM RB frame */
> - write_frame->cmd_buf_addr_hi = upper_32_bits(cmd_buf_mc_addr);
> - write_frame->cmd_buf_addr_lo = lower_32_bits(cmd_buf_mc_addr);
> - write_frame->fence_addr_hi = upper_32_bits(fence_mc_addr);
> - write_frame->fence_addr_lo = lower_32_bits(fence_mc_addr);
> - write_frame->fence_value = index;
> - amdgpu_asic_flush_hdp(adev, NULL);
> -
> - /* Update the write Pointer in DWORDs */
> - psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw;
> - WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_67, psp_write_ptr_reg);
> -
> - return 0;
> -}
> -
> static int
> psp_v10_0_sram_map(struct amdgpu_device *adev,
> unsigned int *sram_offset, unsigned int *sram_addr_reg_offset,
> @@ -424,7 +376,6 @@ static const struct psp_funcs psp_v10_0_funcs = {
> .ring_create = psp_v10_0_ring_create,
> .ring_stop = psp_v10_0_ring_stop,
> .ring_destroy = psp_v10_0_ring_destroy,
> - .cmd_submit = psp_v10_0_cmd_submit,
> .compare_sram_data = psp_v10_0_compare_sram_data,
> .mode1_reset = psp_v10_0_mode1_reset,
> .ring_get_wptr = psp_v10_0_ring_get_wptr,
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index 79fa2c655857..0dcf6d4277c2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -517,63 +517,6 @@ static int psp_v11_0_ring_destroy(struct psp_context *psp,
> return ret;
> }
>
> -static int psp_v11_0_cmd_submit(struct psp_context *psp,
> - uint64_t cmd_buf_mc_addr, uint64_t fence_mc_addr,
> - int index)
> -{
> - unsigned int psp_write_ptr_reg = 0;
> - struct psp_gfx_rb_frame *write_frame = psp->km_ring.ring_mem;
> - struct psp_ring *ring = &psp->km_ring;
> - struct psp_gfx_rb_frame *ring_buffer_start = ring->ring_mem;
> - struct psp_gfx_rb_frame *ring_buffer_end = ring_buffer_start +
> - ring->ring_size / sizeof(struct psp_gfx_rb_frame) - 1;
> - struct amdgpu_device *adev = psp->adev;
> - uint32_t ring_size_dw = ring->ring_size / 4;
> - uint32_t rb_frame_size_dw = sizeof(struct psp_gfx_rb_frame) / 4;
> -
> - /* KM (GPCOM) prepare write pointer */
> - if (psp_v11_0_support_vmr_ring(psp))
> - psp_write_ptr_reg = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_102);
> - else
> - psp_write_ptr_reg = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_67);
> -
> - /* Update KM RB frame pointer to new frame */
> - /* write_frame ptr increments by size of rb_frame in bytes */
> - /* psp_write_ptr_reg increments by size of rb_frame in DWORDs */
> - if ((psp_write_ptr_reg % ring_size_dw) == 0)
> - write_frame = ring_buffer_start;
> - else
> - write_frame = ring_buffer_start + (psp_write_ptr_reg / rb_frame_size_dw);
> - /* Check invalid write_frame ptr address */
> - if ((write_frame < ring_buffer_start) || (ring_buffer_end < write_frame)) {
> - DRM_ERROR("ring_buffer_start = %p; ring_buffer_end = %p; write_frame = %p\n",
> - ring_buffer_start, ring_buffer_end, write_frame);
> - DRM_ERROR("write_frame is pointing to address out of bounds\n");
> - return -EINVAL;
> - }
> -
> - /* Initialize KM RB frame */
> - memset(write_frame, 0, sizeof(struct psp_gfx_rb_frame));
> -
> - /* Update KM RB frame */
> - write_frame->cmd_buf_addr_hi = upper_32_bits(cmd_buf_mc_addr);
> - write_frame->cmd_buf_addr_lo = lower_32_bits(cmd_buf_mc_addr);
> - write_frame->fence_addr_hi = upper_32_bits(fence_mc_addr);
> - write_frame->fence_addr_lo = lower_32_bits(fence_mc_addr);
> - write_frame->fence_value = index;
> - amdgpu_asic_flush_hdp(adev, NULL);
> -
> - /* Update the write Pointer in DWORDs */
> - psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw;
> - if (psp_v11_0_support_vmr_ring(psp)) {
> - WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_102, psp_write_ptr_reg);
> - WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_101, GFX_CTRL_CMD_ID_CONSUME_CMD);
> - } else
> - WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_67, psp_write_ptr_reg);
> -
> - return 0;
> -}
> -
> static int
> psp_v11_0_sram_map(struct amdgpu_device *adev,
> unsigned int *sram_offset, unsigned int *sram_addr_reg_offset,
> @@ -1099,7 +1042,6 @@ static const struct psp_funcs psp_v11_0_funcs = {
> .ring_create = psp_v11_0_ring_create,
> .ring_stop = psp_v11_0_ring_stop,
> .ring_destroy = psp_v11_0_ring_destroy,
> - .cmd_submit = psp_v11_0_cmd_submit,
> .compare_sram_data = psp_v11_0_compare_sram_data,
> .mode1_reset = psp_v11_0_mode1_reset,
> .xgmi_get_topology_info = psp_v11_0_xgmi_get_topology_info,
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c
> index 75b3f9d15a18..58d8b6d732e8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c
> @@ -334,63 +334,6 @@ static int psp_v12_0_ring_destroy(struct psp_context *psp,
> return ret;
> }
>
> -static int psp_v12_0_cmd_submit(struct psp_context *psp,
> - uint64_t cmd_buf_mc_addr, uint64_t fence_mc_addr,
> - int index)
> -{
> - unsigned int psp_write_ptr_reg = 0;
> - struct psp_gfx_rb_frame *write_frame = psp->km_ring.ring_mem;
> - struct psp_ring *ring = &psp->km_ring;
> - struct psp_gfx_rb_frame *ring_buffer_start = ring->ring_mem;
> - struct psp_gfx_rb_frame *ring_buffer_end = ring_buffer_start +
> - ring->ring_size / sizeof(struct psp_gfx_rb_frame) - 1;
> - struct amdgpu_device *adev = psp->adev;
> - uint32_t ring_size_dw = ring->ring_size / 4;
> - uint32_t rb_frame_size_dw = sizeof(struct psp_gfx_rb_frame) / 4;
> -
> - /* KM (GPCOM) prepare write pointer */
> - if (psp_v12_0_support_vmr_ring(psp))
> - psp_write_ptr_reg = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_102);
> - else
> - psp_write_ptr_reg = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_67);
> -
> - /* Update KM RB frame pointer to new frame */
> - /* write_frame ptr increments by size of rb_frame in bytes */
> - /* psp_write_ptr_reg increments by size of rb_frame in DWORDs */
> - if ((psp_write_ptr_reg % ring_size_dw) == 0)
> - write_frame = ring_buffer_start;
> - else
> - write_frame = ring_buffer_start + (psp_write_ptr_reg / rb_frame_size_dw);
> - /* Check invalid write_frame ptr address */
> - if ((write_frame < ring_buffer_start) || (ring_buffer_end < write_frame)) {
> - DRM_ERROR("ring_buffer_start = %p; ring_buffer_end = %p; write_frame = %p\n",
> - ring_buffer_start, ring_buffer_end, write_frame);
> - DRM_ERROR("write_frame is pointing to address out of bounds\n");
> - return -EINVAL;
> - }
> -
> - /* Initialize KM RB frame */
> - memset(write_frame, 0, sizeof(struct psp_gfx_rb_frame));
> -
> - /* Update KM RB frame */
> - write_frame->cmd_buf_addr_hi = upper_32_bits(cmd_buf_mc_addr);
> - write_frame->cmd_buf_addr_lo = lower_32_bits(cmd_buf_mc_addr);
> - write_frame->fence_addr_hi = upper_32_bits(fence_mc_addr);
> - write_frame->fence_addr_lo = lower_32_bits(fence_mc_addr);
> - write_frame->fence_value = index;
> - amdgpu_asic_flush_hdp(adev, NULL);
> -
> - /* Update the write Pointer in DWORDs */
> - psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw;
> - if (psp_v12_0_support_vmr_ring(psp)) {
> - WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_102, psp_write_ptr_reg);
> - WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_101, GFX_CTRL_CMD_ID_CONSUME_CMD);
> - } else
> - WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_67, psp_write_ptr_reg);
> -
> - return 0;
> -}
> -
> static int
> psp_v12_0_sram_map(struct amdgpu_device *adev,
> unsigned int *sram_offset, unsigned int *sram_addr_reg_offset,
> @@ -579,7 +522,6 @@ static const struct psp_funcs psp_v12_0_funcs = {
> .ring_create = psp_v12_0_ring_create,
> .ring_stop = psp_v12_0_ring_stop,
> .ring_destroy = psp_v12_0_ring_destroy,
> - .cmd_submit = psp_v12_0_cmd_submit,
> .compare_sram_data = psp_v12_0_compare_sram_data,
> .mode1_reset = psp_v12_0_mode1_reset,
> .ring_get_wptr = psp_v12_0_ring_get_wptr,
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> index 1de86e550a90..839806cf1c6a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> @@ -408,65 +408,6 @@ static int psp_v3_1_ring_destroy(struct psp_context *psp,
> return ret;
> }
>
> -static int psp_v3_1_cmd_submit(struct psp_context *psp,
> - uint64_t cmd_buf_mc_addr, uint64_t fence_mc_addr,
> - int index)
> -{
> - unsigned int psp_write_ptr_reg = 0;
> - struct psp_gfx_rb_frame * write_frame = psp->km_ring.ring_mem;
> - struct psp_ring *ring = &psp->km_ring;
> - struct psp_gfx_rb_frame *ring_buffer_start = ring->ring_mem;
> - struct psp_gfx_rb_frame *ring_buffer_end = ring_buffer_start +
> - ring->ring_size / sizeof(struct psp_gfx_rb_frame) - 1;
> - struct amdgpu_device *adev = psp->adev;
> - uint32_t ring_size_dw = ring->ring_size / 4;
> - uint32_t rb_frame_size_dw = sizeof(struct psp_gfx_rb_frame) / 4;
> -
> - /* KM (GPCOM) prepare write pointer */
> - if (psp_v3_1_support_vmr_ring(psp))
> - psp_write_ptr_reg = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_102);
> - else
> - psp_write_ptr_reg = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_67);
> -
> - /* Update KM RB frame pointer to new frame */
> - /* write_frame ptr increments by size of rb_frame in bytes */
> - /* psp_write_ptr_reg increments by size of rb_frame in DWORDs */
> - if ((psp_write_ptr_reg % ring_size_dw) == 0)
> - write_frame = ring_buffer_start;
> - else
> - write_frame = ring_buffer_start + (psp_write_ptr_reg / rb_frame_size_dw);
> - /* Check invalid write_frame ptr address */
> - if ((write_frame < ring_buffer_start) || (ring_buffer_end < write_frame)) {
> - DRM_ERROR("ring_buffer_start = %p; ring_buffer_end = %p; write_frame = %p\n",
> - ring_buffer_start, ring_buffer_end, write_frame);
> - DRM_ERROR("write_frame is pointing to address out of bounds\n");
> - return -EINVAL;
> - }
> -
> - /* Initialize KM RB frame */
> - memset(write_frame, 0, sizeof(struct psp_gfx_rb_frame));
> -
> - /* Update KM RB frame */
> - write_frame->cmd_buf_addr_hi = upper_32_bits(cmd_buf_mc_addr);
> - write_frame->cmd_buf_addr_lo = lower_32_bits(cmd_buf_mc_addr);
> - write_frame->fence_addr_hi = upper_32_bits(fence_mc_addr);
> - write_frame->fence_addr_lo = lower_32_bits(fence_mc_addr);
> - write_frame->fence_value = index;
> - amdgpu_asic_flush_hdp(adev, NULL);
> -
> - /* Update the write Pointer in DWORDs */
> - psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw;
> - if (psp_v3_1_support_vmr_ring(psp)) {
> - WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_102, psp_write_ptr_reg);
> - /* send interrupt to PSP for SRIOV ring write pointer update */
> - WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_101,
> - GFX_CTRL_CMD_ID_CONSUME_CMD);
> - } else
> - WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_67, psp_write_ptr_reg);
> -
> - return 0;
> -}
> -
> static int
> psp_v3_1_sram_map(struct amdgpu_device *adev,
> unsigned int *sram_offset, unsigned int *sram_addr_reg_offset,
> @@ -673,7 +614,6 @@ static const struct psp_funcs psp_v3_1_funcs = {
> .ring_create = psp_v3_1_ring_create,
> .ring_stop = psp_v3_1_ring_stop,
> .ring_destroy = psp_v3_1_ring_destroy,
> - .cmd_submit = psp_v3_1_cmd_submit,
> .compare_sram_data = psp_v3_1_compare_sram_data,
> .smu_reload_quirk = psp_v3_1_smu_reload_quirk,
> .mode1_reset = psp_v3_1_mode1_reset,
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
