RE: [PATCH 01/12] amdgpu: add UAPI for creating encrypted buffers

["Liu, Aaron" <Aaron.Liu@xxxxxxx>]

Thanks for reviews.

 

As Christian’s suggestion, I added drm_version checking, for the older driver, security test suites are disabled.

I create a remote branch for libdrm: remotes/origin/aaliu/for-tmz-support

 

BR,

Aaron Liu

 

From: Olsak, Marek <Marek.Olsak@xxxxxxx>
Sent: Saturday, November 16, 2019 3:53 AM
To: Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Cc: Christian König <ckoenig.leichtzumerken@xxxxxxxxx>; Liu, Aaron <Aaron.Liu@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Huang, Ray <Ray.Huang@xxxxxxx>; Tuikov, Luben <Luben.Tuikov@xxxxxxx>; Liu, Leo <Leo.Liu@xxxxxxx>
Subject: Re: [PATCH 01/12] amdgpu: add UAPI for creating encrypted buffers

 

The way this is upstreamed is that you submit the kernel and userspace patches for review at the same time. When they see the userspace patches, the kernel patches will be accepted. When the kernel patches land in the Dave's or Linus's tree, the userspace patches can be pushed.

 

Marek

---

From: Olsak, Marek <Marek.Olsak@xxxxxxx>
Sent: November 15, 2019 14:34
To: Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Cc: Christian König <ckoenig.leichtzumerken@xxxxxxxxx>; Liu, Aaron <Aaron.Liu@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; Tuikov, Luben <Luben.Tuikov@xxxxxxx>; Liu, Leo <Leo.Liu@xxxxxxx>
Subject: Re: [PATCH 01/12] amdgpu: add UAPI for creating encrypted buffers

 

In the kernel tree, you need to do "make headers_install". Then copy amdgpu_drm.h from ./usr/ to the libdrm tree and discard parts that we can't upstream (freesync).

 

Marek

---

From: Koenig, Christian <Christian.Koenig@xxxxxxx>
Sent: November 15, 2019 10:08
To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Cc: Christian König <ckoenig.leichtzumerken@xxxxxxxxx>; Liu, Aaron <Aaron.Liu@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>; Olsak, Marek <Marek.Olsak@xxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; Tuikov, Luben <Luben.Tuikov@xxxxxxx>; Liu, Leo <Leo.Liu@xxxxxxx>
Subject: Re: [PATCH 01/12] amdgpu: add UAPI for creating encrypted buffers

 

I know, that's the usual chicken and egg problem with updating libdrm.

 

But we should update the file with the kernel version and not pick all changes line by line.

 

Christian.

 

Am 15.11.2019 15:49 schrieb "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>:

We can't land the kernel side until we have real userspace (e.g., Mesa) that uses the TMZ interfaces.  The unit tests are not enough.

 

Alex

 

 

---

From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx>
Sent: Friday, November 15, 2019 7:56 AM
To: Liu, Aaron <Aaron.Liu@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Cc: Olsak, Marek <Marek.Olsak@xxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; Tuikov, Luben <Luben.Tuikov@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Liu, Leo <Leo.Liu@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>
Subject: Re: [PATCH 01/12] amdgpu: add UAPI for creating encrypted buffers

 

Am 15.11.19 um 04:34 schrieb Aaron Liu:
> From: Huang Rui <ray.huang@xxxxxxx>
>
> To align the kernel uapi change from Alex:
>
> "Add a flag to the GEM_CREATE ioctl to create encrypted buffers. Buffers with
> this flag set will be created with the TMZ bit set in the PTEs or engines
> accessing them. This is required in order to properly access the data from the
> engines."
>
> We will use GEM_CREATE_ENCRYPTED flag for secure buffer allocation.
>
> Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

Please read up on how amdpu_drm.h is updated. The change must first land
upstream and then the file is synced up somehow semi-automatic.

Christian.

> ---
>   include/drm/amdgpu_drm.h | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
> index 5c28aa7..1a95e37 100644
> --- a/include/drm/amdgpu_drm.h
> +++ b/include/drm/amdgpu_drm.h
> @@ -141,6 +141,11 @@ extern "C" {
>    * releasing the memory
>    */
>   #define AMDGPU_GEM_CREATE_VRAM_WIPE_ON_RELEASE      (1 << 9)
> +/* Flag that BO will be encrypted and that the TMZ bit should be
> + * set in the PTEs when mapping this buffer via GPUVM or
> + * accessing it with various hw blocks
> + */
> +#define AMDGPU_GEM_CREATE_ENCRYPTED          (1 << 10)
>  
>   /* Hybrid specific */
>   /* Flag that the memory allocation should be from top of domain */

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx