I think Kent has more insight with demand for this feature than I do, so I defer to his opinion. I haven't received any feedback on that API.
Main thing is that if it's not supported, don't have the file visible.
Thanks,
Chris
-----Original Message-----
From: Russell, Kent <Kent.Russell@xxxxxxx>
Sent: Thursday, November 7, 2019 8:05 AM
To: Alex Deucher <alexdeucher@xxxxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx>
Cc: Li, Candice <Candice.Li@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Freehill, Chris <Chris.Freehill@xxxxxxx>
Subject: RE: [PATCH] drm/amd/powerplay: correct Arcturus OD support
While we do like OverDrive being available (mostly our open-source community users who are using consumer cards vs server cards), if it's not supported on the HW for whatever reason, we'll adapt. If we get a request later for its enablement (since OverDrive is consumer-card-only in general, and I personally haven't seen any Arcturus consumer cards), we can discuss then. It's fine with Chris and I in that regard.
Kent
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex Deucher
Sent: Thursday, November 7, 2019 8:58 AM
To: Quan, Evan <Evan.Quan@xxxxxxx>
Cc: Li, Candice <Candice.Li@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Freehill, Chris <Chris.Freehill@xxxxxxx>
Subject: Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support
On Thu, Nov 7, 2019 at 2:38 AM Quan, Evan <Evan.Quan@xxxxxxx> wrote:
>
> OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs
> interface is also not supported.
>
> Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf
> Signed-off-by: Evan Quan <evan.quan@xxxxxxx>
You might want to check with Chris and Kent about this. I think there is a use case for OD on ROCm in some cases. Assuming they are ok with it,
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
Alex
> ---
> drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index c21fe7ac5df8..76a4154b3be2 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device
> *adev) {
> struct smu_context *smu = &adev->smu;
>
> + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK)
> + smu->od_enabled = true;
> +
> switch (adev->asic_type) {
> case CHIP_VEGA20:
> vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static
> int smu_set_funcs(struct amdgpu_device *adev)
> break;
> case CHIP_ARCTURUS:
> arcturus_set_ppt_funcs(smu);
> + /* OD is not supported on Arcturus */
> + smu->od_enabled =false;
> break;
> case CHIP_RENOIR:
> renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static
> int smu_set_funcs(struct amdgpu_device *adev)
> return -EINVAL;
> }
>
> - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK)
> - smu->od_enabled = true;
> -
> return 0;
> }
>
> --
> 2.23.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
