Reviewed-by: Marek Olšák <marek.olsak@xxxxxxx>
Marek
From: Zhu, Changfeng <Changfeng.Zhu@xxxxxxx>
Sent: November 4, 2019 02:07 To: Cui, Flora <Flora.Cui@xxxxxxx>; brahma_sw_dev <brahma_sw_dev@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Liu, Aaron <Aaron.Liu@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; Huang, Shimmer <Xinmei.Huang@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Olsak, Marek <Marek.Olsak@xxxxxxx> Subject: RE: enable dispatch/draw tests for renoir Thanks for review, Flora.
Hi Alex & Marek,
Here is a libdrm patch for Renoir dispatch/draw tests.
Could you please help review it? It needs to be upstream.
BR, Changfeng.
From: Cui, Flora <Flora.Cui@xxxxxxx>
Good catch. rb
From: Zhu, Changfeng <Changfeng.Zhu@xxxxxxx>
Hi Ray & Flora,
It can run dispatch/draw tests on new Renoir chips. So we can take back dispatch/draw tests for Renoir.
Could you please help review this patch?
From 793b7fd4dd1580f29e27bd2a90da787535abee14 Mon Sep 17 00:00:00 2001 From: changzhu <Changfeng.Zhu@xxxxxxx> Date: Mon, 4 Nov 2019 11:48:19 +0800 Subject: [PATCH libdrm] tests/amdgpu: enable dispatch/draw tests for Renoir
It can run dispatch/draw tests on new renoir chips. So it needs to enable dispatch/draw tests for Renoir again.
Change-Id: I3a72a4bbfe0fc663ee0e3e58d8e9c304f513e568 Signed-off-by: changzhu <Changfeng.Zhu@xxxxxxx> --- tests/amdgpu/basic_tests.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c index e75b9d0d..a57dcbb4 100644 --- a/tests/amdgpu/basic_tests.c +++ b/tests/amdgpu/basic_tests.c @@ -592,20 +592,6 @@ int suite_basic_tests_init(void)
family_id = gpu_info.family_id;
- if (gpu_info.asic_id == 0x1636) { - if (amdgpu_set_test_active("Basic Tests", - "Dispatch Test", - CU_FALSE)) - fprintf(stderr, "test deactivation failed - %s\n", - CU_get_error_msg()); - - if (amdgpu_set_test_active("Basic Tests", - "Draw Test", - CU_FALSE)) - fprintf(stderr, "test deactivation failed - %s\n", - CU_get_error_msg()); - } - return CUE_SUCCESS; }
@@ -2992,7 +2978,7 @@ void amdgpu_memset_draw(amdgpu_device_handle device_handle, resources[1] = bo_shader_ps; resources[2] = bo_shader_vs; resources[3] = bo_cmd; - r = amdgpu_bo_list_create(device_handle, 3, resources, NULL, &bo_list); + r = amdgpu_bo_list_create(device_handle, 4, resources, NULL, &bo_list); CU_ASSERT_EQUAL(r, 0);
ib_info.ib_mc_address = mc_address_cmd; -- 2.17.1
BR, Changfeng. |
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx