On 2019-11-04 2:49 p.m., Liu, Zhan wrote:
> Thank you Nick for the advice. I just reverted the original commit.
>
> Zhan
The revert still needs code review.
Nicholas Kazlauskas
>
>> -----Original Message-----
>> From: Kazlauskas, Nicholas <Nicholas.Kazlauskas@xxxxxxx>
>> Sent: 2019/November/04, Monday 11:53 AM
>> To: Liu, Zhan <Zhan.Liu@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Wu,
>> Hersen <hersenxs.wu@xxxxxxx>
>> Subject: Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice"
>> workaround
>>
>> On 2019-11-04 11:06 a.m., Liu, Zhan wrote:
>>> [Why]
>>> The root cause of Navi14 HDMI pink screen issue has been found.
>>> There is no need to set DIG_MODE twice anymore.
>>>
>>> [How]
>>> Remove "setting DIG_MODE" twice workaround.
>>>
>>> Signed-off-by: Zhan Liu <zhan.liu@xxxxxxx>
>>
>> Please use git to revert the commit instead:
>>
>> eg.
>>
>> git revert <SHA>
>>
>> Then add the reasoning to the revert commit message.
>>
>> Thanks,
>>
>> Nicholas Kazlauskas
>>
>>> ---
>>> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 ---------
>>> 1 file changed, 9 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>>> index cc94c1a73daa..12ba6fdf89b7 100644
>>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>>> @@ -3027,15 +3027,6 @@ void core_link_enable_stream(
>>> CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
>>> COLOR_DEPTH_UNDEFINED);
>>>
>>> - /* This second call is needed to reconfigure the DIG
>>> - * as a workaround for the incorrect value being applied
>>> - * from transmitter control.
>>> - */
>>> - if (!dc_is_virtual_signal(pipe_ctx->stream->signal))
>>> - stream->link->link_enc->funcs->setup(
>>> - stream->link->link_enc,
>>> - pipe_ctx->stream->signal);
>>> -
>>> #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
>>> if (pipe_ctx->stream->timing.flags.DSC) {
>>> if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
>>> --
>>> 2.21.0
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
