Thanks, done. Best wishes Emily Deng >-----Original Message----- >From: Yuan, Xiaojie <Xiaojie.Yuan@xxxxxxx> >Sent: Monday, November 4, 2019 11:41 AM >To: Deng, Emily <Emily.Deng@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx >Subject: Re: [PATCH v2] drm/amdgpu: Need to free discovery memory > >Please use 'drm/amdgpu/discovery: ' prefix in commit message to let us easily >track all discovery-releated changes. >Other than this, patch is Reviewed-by: Xiaojie Yuan <xiaojie.yuan@xxxxxxx> > >BR, >Xiaojie > >________________________________________ >From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Emily >Deng <Emily.Deng@xxxxxxx> >Sent: Monday, November 4, 2019 11:03 AM >To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx >Cc: Deng, Emily >Subject: [PATCH v2] drm/amdgpu: Need to free discovery memory > >When unloading driver, need to free discovery memory. > >Signed-off-by: Emily Deng <Emily.Deng@xxxxxxx> >--- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >index 28b09f6..7cbe6d9 100644 >--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >@@ -2106,9 +2106,6 @@ void amdgpu_ttm_late_init(struct amdgpu_device >*adev) > void *stolen_vga_buf; > /* return the VGA stolen memory (if any) back to VRAM */ > amdgpu_bo_free_kernel(&adev->stolen_vga_memory, NULL, >&stolen_vga_buf); >- >- /* return the IP Discovery TMR memory back to VRAM */ >- amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL); > } > > /** >@@ -2121,7 +2118,10 @@ void amdgpu_ttm_fini(struct amdgpu_device >*adev) > > amdgpu_ttm_debugfs_fini(adev); > amdgpu_ttm_training_reserve_vram_fini(adev); >+ /* return the IP Discovery TMR memory back to VRAM */ >+ amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL); > amdgpu_ttm_fw_reserve_vram_fini(adev); >+ > if (adev->mman.aper_base_kaddr) > iounmap(adev->mman.aper_base_kaddr); > adev->mman.aper_base_kaddr = NULL; >-- >2.7.4 > >_______________________________________________ >amd-gfx mailing list >amd-gfx@xxxxxxxxxxxxxxxxxxxxx >https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
