|
> -----Original Message----- > From: Chen, Guchun <Guchun.Chen@xxxxxxx> > Sent: Tuesday, October 29, 2019 9:28 AM > To: Ma, Le <Le.Ma@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Ma, Le <Le.Ma@xxxxxxx> > Subject: RE: [PATCH 2/4] drm/amdgpu: reset err_event_athub flag if gpu > recovery succeeded > > > > Regards, > Guchun > > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Le Ma > Sent: Monday, October 28, 2019 7:31 PM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Ma, Le <Le.Ma@xxxxxxx> > Subject: [PATCH 2/4] drm/amdgpu: reset err_event_athub flag if gpu recovery > succeeded > > Otherwise next err_event_athub error cannot call gpu reset. > > Change-Id: I5cd293f30f23876bf2a1860681bcb50f47713ecd > Signed-off-by: Le Ma <le.ma@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 676cad1..51d74bb 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -4089,6 +4089,9 @@ int amdgpu_device_gpu_recover(struct > amdgpu_device *adev, > } > } > > + if (!r && in_ras_intr) > + atomic_set(&amdgpu_ras_in_intr, 0); > [Guchun]To access this atomic variable, maybe it's better we create a new > function like reset or clear in amdgpu_ras.h or .c first, then we can call that > function here, like we we do to amdgpu_ras_intr_triggered in this same > function. This will do assist to modularity of ras driver. >
[Le] Agree with you. We could make it paired with amdgpu_ras_intr_triggered. > skip_sched_resume: > list_for_each_entry(tmp_adev, device_list_handle, gmc.xgmi.head) { > /*unlock kfd: SRIOV would do it separately */ > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list |
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
