Maybe say parameter instead of variable in the subject. Am 23.10.19 um 16:35 schrieb Nirmoy Das: > Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxx> Apart from that Acked-by: Christian König <christian.koenig@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 +-- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 3 +-- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- > 5 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c > index 069515f57c2a..c9d1fada6188 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c > @@ -319,8 +319,7 @@ int amdgpu_gfx_kiq_init_ring(struct amdgpu_device *adev, > return r; > } > > -void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring, > - struct amdgpu_irq_src *irq) > +void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring) > { > amdgpu_device_wb_free(ring->adev, ring->adev->virt.reg_val_offs); > amdgpu_ring_fini(ring); > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h > index 35eff9e6ce16..459aa9059542 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h > @@ -330,8 +330,7 @@ int amdgpu_gfx_kiq_init_ring(struct amdgpu_device *adev, > struct amdgpu_ring *ring, > struct amdgpu_irq_src *irq); > > -void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring, > - struct amdgpu_irq_src *irq); > +void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring); > > void amdgpu_gfx_kiq_fini(struct amdgpu_device *adev); > int amdgpu_gfx_kiq_init(struct amdgpu_device *adev, > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > index 8fca6ab5fa8f..ac43b1af69e3 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > @@ -1443,7 +1443,7 @@ static int gfx_v10_0_sw_fini(void *handle) > amdgpu_ring_fini(&adev->gfx.compute_ring[i]); > > amdgpu_gfx_mqd_sw_fini(adev); > - amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring, &adev->gfx.kiq.irq); > + amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring); > amdgpu_gfx_kiq_fini(adev); > > gfx_v10_0_pfp_fini(adev); > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > index a7fe0ea24d1f..e4c645da4e28 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > @@ -2103,7 +2103,7 @@ static int gfx_v8_0_sw_fini(void *handle) > amdgpu_ring_fini(&adev->gfx.compute_ring[i]); > > amdgpu_gfx_mqd_sw_fini(adev); > - amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring, &adev->gfx.kiq.irq); > + amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring); > amdgpu_gfx_kiq_fini(adev); > > gfx_v8_0_mec_fini(adev); > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > index dd345fcedb97..9fe95e7693d5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > @@ -2153,7 +2153,7 @@ static int gfx_v9_0_sw_fini(void *handle) > amdgpu_ring_fini(&adev->gfx.compute_ring[i]); > > amdgpu_gfx_mqd_sw_fini(adev); > - amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring, &adev->gfx.kiq.irq); > + amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring); > amdgpu_gfx_kiq_fini(adev); > > gfx_v9_0_mec_fini(adev); _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx