On Wed, Oct 16, 2019 at 06:35:15AM +0000, Oleksandr Andrushchenko wrote: > On 10/16/19 8:11 AM, Jürgen Groß wrote: > > On 15.10.19 20:12, Jason Gunthorpe wrote: > >> From: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > >> > >> DMA_SHARED_BUFFER can not be enabled by the user (it represents a > >> library > >> set in the kernel). The kconfig convention is to use select for such > >> symbols so they are turned on implicitly when the user enables a kconfig > >> that needs them. > >> > >> Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable. > >> > >> Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UAPI") > >> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx> > >> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> > >> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx > >> Cc: Juergen Gross <jgross@xxxxxxxx> > >> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx> > >> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > > > > Reviewed-by: Juergen Gross <jgross@xxxxxxxx> > > > Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx> Thanks Oleksandr and Juergen, can you also give me some advice on how to progress the more complex patch: https://patchwork.kernel.org/patch/11191369/ Is this gntdev stuff still in-use? I struggled a bit to understand what it is doing, but I think I made a reasonable guess? Jason _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx