I think the first thing that Alex will say is "please include a commit description". Why did you revert it? Kent -----Original Message----- From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Kim, Jonathan Sent: Friday, October 18, 2019 1:31 PM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Kuehling, Felix <Felix.Kuehling@xxxxxxx>; Kim, Jonathan <Jonathan.Kim@xxxxxxx> Subject: [PATCH 1/2] Revert "drm/amdgpu: fix compiler warnings for df perfmons" This reverts commit 7dd2eb31fcd564574e8efea6bf23cf504f9e2fd7. Signed-off-by: Jonathan Kim <Jonathan.Kim@xxxxxxx> --- drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c index e1cf7e9c616a..f403c62c944e 100644 --- a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c +++ b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c @@ -93,7 +93,7 @@ const struct attribute_group *df_v3_6_attr_groups[] = { NULL }; -static int df_v3_6_set_df_cstate(struct amdgpu_device *adev, int allow) +static df_v3_6_set_df_cstate(struct amdgpu_device *adev, int allow) { int r = 0; @@ -546,7 +546,7 @@ static void df_v3_6_pmc_get_count(struct amdgpu_device *adev, uint64_t config, uint64_t *count) { - uint32_t lo_base_addr, hi_base_addr, lo_val = 0, hi_val = 0; + uint32_t lo_base_addr, hi_base_addr, lo_val, hi_val; *count = 0; switch (adev->asic_type) { -- 2.17.1 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx