Hi Zhan,
I tested your patch, and it fixed the issue. I have some notes:
1. Your patch does not apply smoothly, try to rebase your branch (I
manually fix it for testing your patch).
2. In the commit message, I recommend you to describe the "pink" color
issue when using HDMI. It is going to make easy to understand the issue
that your patch is trying to fix.
Thanks
On 10/17, Liu, Zhan wrote:
> From: Zhan Liu <zhan.liu@xxxxxxx>
>
> [Why]
> When a specific kind of connector is detected,
> DC needs to set the attribute of the stream.
> This step needs to be done before enabling link,
> or some bugs (e.g. display won't light up)
> will be observed.
>
> [How]
> Setting the attribute of the stream first, then
> enabling stream.
>
> Signed-off-by: Zhan Liu <zhan.liu@xxxxxxx>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index fb18681b502b..713caab82837 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -2745,16 +2745,6 @@ void core_link_enable_stream(
> dc_is_virtual_signal(pipe_ctx->stream->signal))
> return;
>
> - if (!dc_is_virtual_signal(pipe_ctx->stream->signal)) {
> - stream->link->link_enc->funcs->setup(
> - stream->link->link_enc,
> - pipe_ctx->stream->signal);
> - pipe_ctx->stream_res.stream_enc->funcs->setup_stereo_sync(
> - pipe_ctx->stream_res.stream_enc,
> - pipe_ctx->stream_res.tg->inst,
> - stream->timing.timing_3d_format != TIMING_3D_FORMAT_NONE);
> - }
> -
> if (dc_is_dp_signal(pipe_ctx->stream->signal))
> pipe_ctx->stream_res.stream_enc->funcs->dp_set_stream_attribute(
> pipe_ctx->stream_res.stream_enc,
> @@ -2841,6 +2831,16 @@ void core_link_enable_stream(
> CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
> COLOR_DEPTH_UNDEFINED);
>
> + if (!dc_is_virtual_signal(pipe_ctx->stream->signal)) {
> + stream->link->link_enc->funcs->setup(
> + stream->link->link_enc,
> + pipe_ctx->stream->signal);
> + pipe_ctx->stream_res.stream_enc->funcs->setup_stereo_sync(
> + pipe_ctx->stream_res.stream_enc,
> + pipe_ctx->stream_res.tg->inst,
> + stream->timing.timing_3d_format != TIMING_3D_FORMAT_NONE);
> + }
> +
> #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
> if (pipe_ctx->stream->timing.flags.DSC) {
> if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
> --
> 2.17.1
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
--
Rodrigo Siqueira
Software Engineer, Advanced Micro Devices (AMD)
https://siqueira.tech
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
