On Thu, Oct 17, 2019 at 3:51 AM Takashi Iwai <tiwai@xxxxxxx> wrote:
>
> On Fri, 11 Oct 2019 03:45:35 +0200,
> Alex Deucher wrote:
> >
> > We are able to power down the GPU and audio via the GPU driver
> > so flag these asics as supporting runtime pm.
> >
> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
>
> Sorry for the late reply, as I've been off for the last few weeks.
>
> The change itself looks good to me, but maybe it'd be nicer to mention
> that you're adding new IDs, not only flipping the flag of the existing
> entries.
I'll split it into two patches.
>
> Also, you can define a new flag, e.g.
>
> #define AZX_DCAPS_PRESET_ATI_HDMI_PM \
> (AZX_DCAPS_PRESET_ATI_HDMI_NS | AZX_DCAPS_PM_RUNTIME)
>
> and use them instead of open-coding at each place.
> This is just a matter of taste, so I don't mind either way, though.
>
Thanks!
Alex
>
> thanks,
>
> Takashi
>
> > ---
> > sound/pci/hda/hda_intel.c | 35 ++++++++++++++++++++++++++++++-----
> > 1 file changed, 30 insertions(+), 5 deletions(-)
> >
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > index 9b90312d7314..925a95927f20 100644
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -2562,13 +2562,38 @@ static const struct pci_device_id azx_ids[] = {
> > { PCI_DEVICE(0x1002, 0xaac8),
> > .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> > { PCI_DEVICE(0x1002, 0xaad8),
> > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> > - { PCI_DEVICE(0x1002, 0xaae8),
> > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > { PCI_DEVICE(0x1002, 0xaae0),
> > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > + { PCI_DEVICE(0x1002, 0xaae8),
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > { PCI_DEVICE(0x1002, 0xaaf0),
> > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > + { PCI_DEVICE(0x1002, 0xaaf8),
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > + { PCI_DEVICE(0x1002, 0xab00),
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > + { PCI_DEVICE(0x1002, 0xab08),
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > + { PCI_DEVICE(0x1002, 0xab10),
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > + { PCI_DEVICE(0x1002, 0xab18),
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > + { PCI_DEVICE(0x1002, 0xab20),
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > + { PCI_DEVICE(0x1002, 0xab38),
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > /* VIA VT8251/VT8237A */
> > { PCI_DEVICE(0x1106, 0x3288), .driver_data = AZX_DRIVER_VIA },
> > /* VIA GFX VT7122/VX900 */
> > --
> > 2.20.1
> >
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
