|
Thanks Luben!
Patch 8 v2 has sent out, please review again.
From: Tuikov, Luben <Luben.Tuikov@xxxxxxx>
Sent: Wednesday, October 16, 2019 2:01 To: Yin, Tianci (Rico) <Tianci.Yin@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx> Subject: Re: [PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revision Patches 1-7: Looks good.
Reviewed-by: Luben Tuikov <luben.tuikov@xxxxxxx> Patch 8: NAK! for the same exact reason as the previous review. No changes to NAK reasoning from previous review. Regards, Luben On 2019-10-13 11:21 p.m., Tianci Yin wrote: > From: "Tianci.Yin" <tianci.yin@xxxxxxx> > > update amdgpu_discovery to get IP revision. > > Change-Id: If8152103d03b58e1dc0f32db63625e290f5f08a0 > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > Signed-off-by: Tianci.Yin <tianci.yin@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 +++- > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > index 71198c5318e1..ddd8364102a2 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > @@ -333,7 +333,7 @@ int amdgpu_discovery_reg_base_init(struct amdgpu_device *adev) > } > > int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_id, > - int *major, int *minor) > + int *major, int *minor, int *revision) > { > struct binary_header *bhdr; > struct ip_discovery_header *ihdr; > @@ -369,6 +369,8 @@ int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_id, > *major = ip->major; > if (minor) > *minor = ip->minor; > + if (revision) > + *revision = ip->revision; > return 0; > } > ip_offset += sizeof(*ip) + 4 * (ip->num_base_address - 1); > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h > index 5a6693d7d269..ba78e15d9b05 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h > @@ -30,7 +30,7 @@ int amdgpu_discovery_init(struct amdgpu_device *adev); > void amdgpu_discovery_fini(struct amdgpu_device *adev); > int amdgpu_discovery_reg_base_init(struct amdgpu_device *adev); > int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_id, > - int *major, int *minor); > + int *major, int *minor, int *revision); > int amdgpu_discovery_get_gfx_info(struct amdgpu_device *adev); > > #endif /* __AMDGPU_DISCOVERY__ */ > |
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
