Thanks for the patches. I think for all of them we should just drop the REG_READ calls completely. They look like leftovers from when we had a different register update scheme that would read the register, then update or get the field value. Now we just use the REG_ macros that will combine the read with the GET or UPDATE operations. Harry On 2019-10-09 2:25 a.m., zhengbin wrote: > zhengbin (3): > drm/amd/display: Remove set but not used variables > 'bl_pwm_cntl','pwm_period_cntl' > drm/amd/display: Remove set but not used variable 'value0' > drm/amd/display: Remove set but not used variables 'regval','speakers' > > drivers/gpu/drm/amd/display/dc/dce/dce_abm.c | 8 ++++---- > drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 3 +-- > drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c | 5 +---- > 3 files changed, 6 insertions(+), 10 deletions(-) > > -- > 2.7.4 > _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
