On Sun, Sep 29, 2019 at 2:19 AM chen gong <curry.gong@xxxxxxx> wrote: > > Find that ring sdma0 test failed if turn on SDMA powergating after do > mode2 reset. > > Perhaps the mode2 reset does not reset the SDMA PG state, SDMA is > already powered up so there is no need to ask the SMU to power it up > again. So I skip this function for a moment. > > Signed-off-by: chen gong <curry.gong@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > index 96581b5..e0eb2450 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > @@ -1792,7 +1792,7 @@ static int sdma_v4_0_hw_init(void *handle) > > if ((adev->asic_type == CHIP_RAVEN && adev->powerplay.pp_funcs && > adev->powerplay.pp_funcs->set_powergating_by_smu) || > - adev->asic_type == CHIP_RENOIR) > + (adev->asic_type == CHIP_RENOIR && adev->in_gpu_reset != 1)) How about !adev->in_gpu_reset rather than explicitly checking for 1? With that fixed: Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> Alex > amdgpu_dpm_set_powergating_by_smu(adev, AMD_IP_BLOCK_TYPE_SDMA, false); > > if (!amdgpu_sriov_vf(adev)) > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
