Re: [PATCH] drm/amdgpu: fix error handling in amdgpu_bo_list_create

[Christian König <ckoenig.leichtzumerken@xxxxxxxxx>]

Ping? Can I get at least and acked-by for this?

Thanks,
Christian.

Am 18.09.19 um 19:43 schrieb Christian König:
> We need to drop normal and userptr BOs separately.
>
> Signed-off-by: Christian König <christian.koenig@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
> index d497467b7fc6..94908bf269a6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
> @@ -139,7 +139,12 @@ int amdgpu_bo_list_create(struct amdgpu_device *adev, struct drm_file *filp,
>   	return 0;
>   
>   error_free:
> -	while (i--) {
> +	for (i = 0; i < last_entry; ++i) {
> +		struct amdgpu_bo *bo = ttm_to_amdgpu_bo(array[i].tv.bo);
> +
> +		amdgpu_bo_unref(&bo);
> +	}
> +	for (i = first_userptr; i < num_entries; ++i) {
>   		struct amdgpu_bo *bo = ttm_to_amdgpu_bo(array[i].tv.bo);
>   
>   		amdgpu_bo_unref(&bo);

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx