Re: [PATCH] drm/amdkfd: Add NAVI12 support from kfd side

["Zhao, Yong" <Yong.Zhao@xxxxxxx>]

If Navi12 is the same as Navi10, then you can easily add the KFD support first, as it only involves a couple of lines because of recent simplification. Then have this patch next. 

Regards,

Yong

---

From: Liu, Shaoyun <Shaoyun.Liu@xxxxxxx>
Sent: Tuesday, September 24, 2019 6:28 PM
To: Zhao, Yong <Yong.Zhao@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] drm/amdkfd: Add NAVI12 support from kfd side

 

I will push to drm-next branch . After check the code again , this change will cause  issue in the  kfd since CHIP_NAVI12  not added  in other place where check the device_info->asic_family  in kfd code .  I think it's better just set the  family ID as CHIP_NAVI10  since there is no difference from the kfd side for NAVI10, NAVI12 and    NAVI14.  I will send  another review .

Regards

shaoyun.liu 

On 2019-09-24 6:17 p.m., Zhao, Yong wrote:

Reviewed-by: Yong Zhao <Yong.Zhao@xxxxxxx>

Make sure to push to the new 5.3 branch.

Yong

---

From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Liu, Shaoyun <Shaoyun.Liu@xxxxxxx>
Sent: Tuesday, September 24, 2019 6:16 PM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Cc: Liu, Shaoyun <Shaoyun.Liu@xxxxxxx>
Subject: [PATCH] drm/amdkfd: Add NAVI12 support from kfd side

 

Add device info for both navi12 PF and VF

Change-Id: Ifb4035e65c12d153fc30e593fe109f9c7e0541f4
Signed-off-by: shaoyunl <shaoyun.liu@xxxxxxx>
---
 drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index f329b82..edfbae5c 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -387,6 +387,24 @@ static const struct kfd_device_info navi10_device_info = {
         .num_sdma_queues_per_engine = 8,
 };
 
+static const struct kfd_device_info navi12_device_info = {
+       .asic_family = CHIP_NAVI12,
+       .asic_name = "navi12",
+       .max_pasid_bits = 16,
+       .max_no_of_hqd  = 24,
+       .doorbell_size  = 8,
+       .ih_ring_entry_size = 8 * sizeof(uint32_t),
+       .event_interrupt_class = &event_interrupt_class_v9,
+       .num_of_watch_points = 4,
+       .mqd_size_aligned = MQD_SIZE_ALIGNED,
+       .needs_iommu_device = false,
+       .supports_cwsr = true,
+       .needs_pci_atomics = false,
+       .num_sdma_engines = 2,
+       .num_xgmi_sdma_engines = 0,
+       .num_sdma_queues_per_engine = 8,
+};
+
 static const struct kfd_device_info navi14_device_info = {
         .asic_family = CHIP_NAVI14,
         .asic_name = "navi14",
@@ -425,6 +443,7 @@ static const struct kfd_device_info *kfd_supported_devices[][2] = {
         [CHIP_RENOIR] = {&renoir_device_info, NULL},
         [CHIP_ARCTURUS] = {&arcturus_device_info, &arcturus_device_info},
         [CHIP_NAVI10] = {&navi10_device_info, NULL},
+       [CHIP_NAVI12] = {&navi12_device_info, &navi12_device_info},
         [CHIP_NAVI14] = {&navi14_device_info, NULL},
 };
 
--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx