On 9/23/19 2:14 AM, chen gong wrote: > Signed-off-by: chen gong <curry.gong@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/soc15.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c > index 58818761..0f639df9 100644 > --- a/drivers/gpu/drm/amd/amdgpu/soc15.c > +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c > @@ -514,6 +514,8 @@ static int soc15_asic_baco_reset(struct amdgpu_device *adev) > > static int soc15_mode2_reset(struct amdgpu_device *adev) > { > + if (is_support_sw_smu(adev)) > + return smu_mode2_reset(&adev->smu); Picasso reset is also SMU based so I would unify the code for both resets under smu_mode2_reset and already inside would make the distinction between Picasso(RAVEN) and Renoir. Apart from that the series looks good the me. Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@xxxxxxx> Andrey > if (!adev->powerplay.pp_funcs || > !adev->powerplay.pp_funcs->asic_reset_mode_2) > return -ENOENT; > @@ -528,6 +530,7 @@ soc15_asic_reset_method(struct amdgpu_device *adev) > > switch (adev->asic_type) { > case CHIP_RAVEN: > + case CHIP_RENOIR: > return AMD_RESET_METHOD_MODE2; > case CHIP_VEGA10: > case CHIP_VEGA12: _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx