Re: [PATCH] drm/amdgpu: cleanup creating BOs at fixed location

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 16.09.19 um 22:06 schrieb Li, Sun peng (Leo):

On 2019-09-13 8:08 a.m., Christian König wrote:
[SNIP]
-		if (amdgpu_ras_reserve_vram(adev, bp << PAGE_SHIFT,
-					PAGE_SIZE, &bo))
+		if (amdgpu_bo_create_kernel_at(adev, bp << PAGE_SIZE, PAGE_SIZE,
I'm getting a compile warning from the above line:

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1408:43: warning: left shift count >= width of type [-Wshift-count-overflow]
  1408 |   if (amdgpu_bo_create_kernel_at(adev, bp << PAGE_SIZE, PAGE_SIZE,
       |                                           ^~

Should it be << PAGE_SHIFT?

Yeah, Alex already fixed that up yesterday. Sorry that I didn't noticed all those typos earlier, but I don't have hardware to test this.

Christian.


Thanks,
Leo


_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux